Skip to content

Conversation

@ealbasiri
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • [Y ] Have you signed your commits? Use git commit -s to sign.
  • [ Y] Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • [Y ] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • [ Y] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • [Y ] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • [ Y] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • [ Y] Remove import guards (try import: ... except: ...) if not already done.
  • [ Y] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • [ Y] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • [ Y] New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

ealbasiri and others added 2 commits April 27, 2023 16:57
Signed-off-by: ealbasiri <ealbasiri@gradcenter.cuny.edu>
@ealbasiri ealbasiri requested a review from anand-nv April 28, 2023 00:04
@github-actions
Copy link

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 12, 2023
@github-actions github-actions bot removed the Stale label May 13, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 1, 2023
anand-nv and others added 6 commits June 1, 2023 10:36
Signed-off-by: anand-nv <105917641+anand-nv@users.noreply.github.com>
Signed-off-by: anand-nv <105917641+anand-nv@users.noreply.github.com>
Signed-off-by: anand-nv <105917641+anand-nv@users.noreply.github.com>
Signed-off-by: anand-nv <105917641+anand-nv@users.noreply.github.com>
Copy link
Collaborator

@anand-nv anand-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed unused variables/imports

@github-actions github-actions bot removed the Stale label Jun 2, 2023
@anand-nv anand-nv requested a review from mgrafu June 6, 2023 15:03
@mgrafu mgrafu merged commit e08b1b2 into NVIDIA:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants