ci(hooks): add root-level vitest to pre-push hooks#1083
Merged
Conversation
The pre-push hooks only ran vitest for the nemoclaw/ plugin project. Root-level unit tests (test/*.test.js) were only caught by CI's test-unit job, not locally. Add a vitest-root hook that runs --project cli on pre-push so test failures are caught before push.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new pre-commit hook configuration for Vitest unit testing has been added to the pre-push stage. The hook executes Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
cv
approved these changes
Mar 30, 2026
brentrockwood
added a commit
to brentrockwood/NemoClaw
that referenced
this pull request
Mar 30, 2026
log show --last 5m is slow on macOS (~3s), making debug --quick
exceed vitest's 5000ms default timeout. Kernel messages (log show /
dmesg) are not minimal diagnostics — gate them under QUICK=false.
Also add { timeout: 30000 } to the cli.test.js debug --quick test
as a safety net for any remaining slow commands on slower machines.
Fixes the vitest-root pre-push gate introduced in NVIDIA#1083.
laitingsheng
pushed a commit
that referenced
this pull request
Apr 2, 2026
The pre-push hooks only ran vitest for the nemoclaw/ plugin project. Root-level unit tests (test/*.test.js) were only caught by CI's test-unit job, not locally. Add a vitest-root hook that runs --project cli on pre-push so test failures are caught before push.
lakamsani
pushed a commit
to lakamsani/NemoClaw
that referenced
this pull request
Apr 4, 2026
The pre-push hooks only ran vitest for the nemoclaw/ plugin project. Root-level unit tests (test/*.test.js) were only caught by CI's test-unit job, not locally. Add a vitest-root hook that runs --project cli on pre-push so test failures are caught before push.
brentrockwood
added a commit
to brentrockwood/NemoClaw
that referenced
this pull request
Apr 7, 2026
log show --last 5m is slow on macOS (~3s), making debug --quick
exceed vitest's 5000ms default timeout. Kernel messages (log show /
dmesg) are not minimal diagnostics — gate them under QUICK=false.
Also add { timeout: 30000 } to the cli.test.js debug --quick test
as a safety net for any remaining slow commands on slower machines.
Fixes the vitest-root pre-push gate introduced in NVIDIA#1083.
gemini2026
pushed a commit
to gemini2026/NemoClaw
that referenced
this pull request
Apr 14, 2026
The pre-push hooks only ran vitest for the nemoclaw/ plugin project. Root-level unit tests (test/*.test.js) were only caught by CI's test-unit job, not locally. Add a vitest-root hook that runs --project cli on pre-push so test failures are caught before push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root-level unit tests (
test/*.test.js) were only caught by CI'stest-unitjob, never by local pre-push hooks. This meant test failures could be pushed and only discovered in CI.Adds a
vitest-rootpre-push hook that runsnpx vitest run --project cliwhen files inbin/,test/, orscripts/change. Matches what CI'stest-unitjob runs.Changes
.pre-commit-config.yaml— Addvitest-roothook at priority 20 (same as existingvitest-plugin), stagepre-push.Summary by CodeRabbit