Skip to content

fix: align setup-spark.sh with the spark-install.md#1256

Merged
ericksoa merged 4 commits intoNVIDIA:mainfrom
paritoshd-nv:fix/issue-1163-correct-setup-spark
Apr 2, 2026
Merged

fix: align setup-spark.sh with the spark-install.md#1256
ericksoa merged 4 commits intoNVIDIA:mainfrom
paritoshd-nv:fix/issue-1163-correct-setup-spark

Conversation

@paritoshd-nv
Copy link
Copy Markdown
Contributor

@paritoshd-nv paritoshd-nv commented Apr 1, 2026

Fixes: #1163

Now, install.sh does onboarding step. Hence, there is no need to "run nemoclaw onboard" in the setup-spark.sh
This also aligns with the spark setup instructions in the spark-install.md

Summary

Related Issue

Changes

Type of Change

  • Code change for a new feature, bug fix, or refactor.
  • Code change with doc updates.
  • Doc only. Prose changes without code sample modifications.
  • Doc only. Includes code sample changes.

Testing

  • npx prek run --all-files passes (or equivalently make check).
  • npm test passes.
  • make docs builds without warnings. (for doc-only changes)

Checklist

General

Code Changes

  • Formatters applied — npx prek run --all-files auto-fixes formatting (or make format for targeted runs).
  • Tests added or updated for new or changed behavior.
  • No secrets, API keys, or credentials committed.
  • Doc pages updated for any user-facing behavior changes (new commands, changed defaults, new features, bug fixes that contradict existing docs).

Doc Changes

  • Follows the style guide. Try running the update-docs agent skill to draft changes while complying with the style guide. For example, prompt your agent with "/update-docs catch up the docs for the new changes I made in this PR."
  • New pages include SPDX license header and frontmatter, if creating a new page.
  • Cross-references and links verified.

Signed-off-by: Your Name your-email@example.com

Summary by CodeRabbit

  • Chores
    • Streamlined DGX Spark Docker setup instructions by removing a post-configuration guidance prompt.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 544e0238-cc24-4985-af52-9ff7f94cac26

📥 Commits

Reviewing files that changed from the base of the PR and between 97038c0 and 1b8740c.

📒 Files selected for processing (1)
  • scripts/setup-spark.sh
💤 Files with no reviewable changes (1)
  • scripts/setup-spark.sh

📝 Walkthrough

Walkthrough

Removed two informational lines from the DGX Spark Docker setup script that instructed users to run nemoclaw onboard as the next step. This change aligns the script's output with documentation that specifies different next steps.

Changes

Cohort / File(s) Summary
Setup Script Cleanup
scripts/setup-spark.sh
Removed two info lines that instructed users to run nemoclaw onboard after DGX Spark Docker configuration completion. No logic or control flow changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A confusing prompt caused quite a fright,
Two lines removed to set things right,
No more mixed signals, the path is clear,
Documentation and script now aligned, my dear! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the 'nemoclaw onboard' instruction from setup-spark.sh to align it with spark-install.md documentation.
Linked Issues check ✅ Passed The changes directly address issue #1163 by removing the 'nemoclaw onboard' prompt from setup-spark.sh to align with documentation guidance that users should run ./install.sh instead.
Out of Scope Changes check ✅ Passed The changes are narrowly scoped to the specific issue: only two informational lines were removed from the script with no other logic or configuration modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Fixes: NVIDIA#1163

Now, install.sh does onboarding step. Hence, there is no need to
mention "run nemoclaw onboard" in the setup-spark.sh
This also aligns with the spark setup instructions in the spark-install.md

Signed-off-by: Paritosh Dixit <paritoshd@nvidia.com>
@paritoshd-nv paritoshd-nv force-pushed the fix/issue-1163-correct-setup-spark branch from e590e64 to 1b8740c Compare April 1, 2026 15:05
@paritoshd-nv paritoshd-nv requested a review from kjw3 April 1, 2026 15:05
@paritoshd-nv
Copy link
Copy Markdown
Contributor Author

Hi @kjw3 , this is a minor update to script. Please review/approve it.

@paritoshd-nv paritoshd-nv requested a review from ericksoa April 1, 2026 18:47
@wscurran wscurran added documentation Improvements or additions to documentation NemoClaw CLI Use this label to identify issues with the NemoClaw command-line interface (CLI). labels Apr 1, 2026
Copy link
Copy Markdown
Contributor

@ericksoa ericksoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — install.sh handles onboarding now, so the redundant prompt is correctly removed.

@ericksoa ericksoa merged commit f6649f3 into NVIDIA:main Apr 2, 2026
6 checks passed
laitingsheng pushed a commit that referenced this pull request Apr 2, 2026
Fixes: #1163

Now, install.sh does onboarding step. Hence, there is no need to "run
nemoclaw onboard" in the setup-spark.sh
This also aligns with the spark setup instructions in the
spark-install.md

<!-- markdownlint-disable MD041 -->
## Summary
<!-- 1-3 sentences: what this PR does and why. -->

## Related Issue
<!-- Link to the issue: Fixes #NNN or Closes #NNN. Remove this section
if none. -->

## Changes
<!-- Bullet list of key changes. -->

## Type of Change
<!-- Check the one that applies. -->
- [ ] Code change for a new feature, bug fix, or refactor.
- [ ] Code change with doc updates.
- [ ] Doc only. Prose changes without code sample modifications.
- [ ] Doc only. Includes code sample changes.

## Testing
<!-- What testing was done? -->
- [ ] `npx prek run --all-files` passes (or equivalently `make check`).
- [ ] `npm test` passes.
- [ ] `make docs` builds without warnings. (for doc-only changes)

## Checklist

### General

- [ ] I have read and followed the [contributing
guide](https://github.com/NVIDIA/NemoClaw/blob/main/CONTRIBUTING.md).
- [ ] I have read and followed the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md).
(for doc-only changes)

### Code Changes
<!-- Skip if this is a doc-only PR. -->
- [ ] Formatters applied — `npx prek run --all-files` auto-fixes
formatting (or `make format` for targeted runs).
- [ ] Tests added or updated for new or changed behavior.
- [ ] No secrets, API keys, or credentials committed.
- [ ] Doc pages updated for any user-facing behavior changes (new
commands, changed defaults, new features, bug fixes that contradict
existing docs).

### Doc Changes
<!-- Skip if this PR has no doc changes. -->
- [ ] Follows the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md).
Try running the `update-docs` agent skill to draft changes while
complying with the style guide. For example, prompt your agent with
"`/update-docs` catch up the docs for the new changes I made in this
PR."
- [ ] New pages include SPDX license header and frontmatter, if creating
a new page.
- [ ] Cross-references and links verified.

---
<!-- DCO sign-off (required by CI). Replace with your real name and
email. -->
Signed-off-by: Your Name <your-email@example.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Streamlined DGX Spark Docker setup instructions by removing a
post-configuration guidance prompt.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Paritosh Dixit <paritoshd@nvidia.com>
Co-authored-by: Aaron Erickson 🦞 <aerickson@nvidia.com>
lakamsani pushed a commit to lakamsani/NemoClaw that referenced this pull request Apr 4, 2026
Fixes: NVIDIA#1163

Now, install.sh does onboarding step. Hence, there is no need to "run
nemoclaw onboard" in the setup-spark.sh
This also aligns with the spark setup instructions in the
spark-install.md

<!-- markdownlint-disable MD041 -->
## Summary
<!-- 1-3 sentences: what this PR does and why. -->

## Related Issue
<!-- Link to the issue: Fixes #NNN or Closes #NNN. Remove this section
if none. -->

## Changes
<!-- Bullet list of key changes. -->

## Type of Change
<!-- Check the one that applies. -->
- [ ] Code change for a new feature, bug fix, or refactor.
- [ ] Code change with doc updates.
- [ ] Doc only. Prose changes without code sample modifications.
- [ ] Doc only. Includes code sample changes.

## Testing
<!-- What testing was done? -->
- [ ] `npx prek run --all-files` passes (or equivalently `make check`).
- [ ] `npm test` passes.
- [ ] `make docs` builds without warnings. (for doc-only changes)

## Checklist

### General

- [ ] I have read and followed the [contributing
guide](https://github.com/NVIDIA/NemoClaw/blob/main/CONTRIBUTING.md).
- [ ] I have read and followed the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md).
(for doc-only changes)

### Code Changes
<!-- Skip if this is a doc-only PR. -->
- [ ] Formatters applied — `npx prek run --all-files` auto-fixes
formatting (or `make format` for targeted runs).
- [ ] Tests added or updated for new or changed behavior.
- [ ] No secrets, API keys, or credentials committed.
- [ ] Doc pages updated for any user-facing behavior changes (new
commands, changed defaults, new features, bug fixes that contradict
existing docs).

### Doc Changes
<!-- Skip if this PR has no doc changes. -->
- [ ] Follows the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md).
Try running the `update-docs` agent skill to draft changes while
complying with the style guide. For example, prompt your agent with
"`/update-docs` catch up the docs for the new changes I made in this
PR."
- [ ] New pages include SPDX license header and frontmatter, if creating
a new page.
- [ ] Cross-references and links verified.

---
<!-- DCO sign-off (required by CI). Replace with your real name and
email. -->
Signed-off-by: Your Name <your-email@example.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Streamlined DGX Spark Docker setup instructions by removing a
post-configuration guidance prompt.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Paritosh Dixit <paritoshd@nvidia.com>
Co-authored-by: Aaron Erickson 🦞 <aerickson@nvidia.com>
gemini2026 pushed a commit to gemini2026/NemoClaw that referenced this pull request Apr 14, 2026
Fixes: NVIDIA#1163

Now, install.sh does onboarding step. Hence, there is no need to "run
nemoclaw onboard" in the setup-spark.sh
This also aligns with the spark setup instructions in the
spark-install.md

<!-- markdownlint-disable MD041 -->
## Summary
<!-- 1-3 sentences: what this PR does and why. -->

## Related Issue
<!-- Link to the issue: Fixes #NNN or Closes #NNN. Remove this section
if none. -->

## Changes
<!-- Bullet list of key changes. -->

## Type of Change
<!-- Check the one that applies. -->
- [ ] Code change for a new feature, bug fix, or refactor.
- [ ] Code change with doc updates.
- [ ] Doc only. Prose changes without code sample modifications.
- [ ] Doc only. Includes code sample changes.

## Testing
<!-- What testing was done? -->
- [ ] `npx prek run --all-files` passes (or equivalently `make check`).
- [ ] `npm test` passes.
- [ ] `make docs` builds without warnings. (for doc-only changes)

## Checklist

### General

- [ ] I have read and followed the [contributing
guide](https://github.com/NVIDIA/NemoClaw/blob/main/CONTRIBUTING.md).
- [ ] I have read and followed the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md).
(for doc-only changes)

### Code Changes
<!-- Skip if this is a doc-only PR. -->
- [ ] Formatters applied — `npx prek run --all-files` auto-fixes
formatting (or `make format` for targeted runs).
- [ ] Tests added or updated for new or changed behavior.
- [ ] No secrets, API keys, or credentials committed.
- [ ] Doc pages updated for any user-facing behavior changes (new
commands, changed defaults, new features, bug fixes that contradict
existing docs).

### Doc Changes
<!-- Skip if this PR has no doc changes. -->
- [ ] Follows the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md).
Try running the `update-docs` agent skill to draft changes while
complying with the style guide. For example, prompt your agent with
"`/update-docs` catch up the docs for the new changes I made in this
PR."
- [ ] New pages include SPDX license header and frontmatter, if creating
a new page.
- [ ] Cross-references and links verified.

---
<!-- DCO sign-off (required by CI). Replace with your real name and
email. -->
Signed-off-by: Your Name <your-email@example.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Streamlined DGX Spark Docker setup instructions by removing a
post-configuration guidance prompt.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Paritosh Dixit <paritoshd@nvidia.com>
Co-authored-by: Aaron Erickson 🦞 <aerickson@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation NemoClaw CLI Use this label to identify issues with the NemoClaw command-line interface (CLI).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NemoClaw][spark] setup-spark.sh installation prompt is not match document

3 participants