fix(platform): allow shouldPatchCoredns isWsl override for deterministic WSL2 tests

[TSavo]

Summary

Adds an opts.isWsl short-circuit to isWsl() in bin/lib/platform.js so the shouldPatchCoredns test can pin its assertions on every host. Without the override the existing test fails on WSL2 dev machines because os.release() always reports a "microsoft"-tagged kernel string there.

Related Issue

Closes #1621 (sub-item 3 of three: shouldPatchCoredns non-deterministic on WSL2 hosts).

Changes

• bin/lib/platform.js: isWsl() now returns opts.isWsl directly when it's a boolean, before falling through to the existing detection logic. Production callers (which don't pass opts.isWsl) keep the existing behavior unchanged.
• test/platform.test.js: existing shouldPatchCoredns test now passes { isWsl: false } so the runtime-matching assertions exercise the function rather than the kernel. A second test case is added with { isWsl: true } to lock the "skip CoreDNS patching on WSL2" branch so a future change to that branch is caught.

Diff: +23 / −5 across 2 files.

Type of Change

• Code change for a new feature, bug fix, or refactor.
• Code change with doc updates.
• Doc only. Prose changes without code sample modifications.
• Doc only. Includes code sample changes.

Testing

• npx vitest run --project cli test/platform.test.js -t shouldPatchCoredns — both new test cases pass on a WSL2 Ubuntu host (the existing test was the failure that prompted this PR)
• npx prettier --check bin/lib/platform.js test/platform.test.js clean
• npx tsc --noEmit -p tsconfig.cli.json clean
• npx prek run --all-files / npm test — not run on the local machine because the full CLI test suite hits two separate baseline failures on a WSL2 host: this very shouldPatchCoredns issue (which this PR fixes) and the install-preflight sysbin leakage covered by fix(test): isolate sysbin in install-preflight tests to prevent host PATH leakage #1628. Upstream CI runs on Linux runners so it'll exercise the full suite normally.
• make docs builds without warnings. (for doc-only changes — N/A)

Checklist

General

• I have read and followed the contributing guide.
• I have read and followed the style guide. (for doc-only changes — N/A)

Code Changes

• Formatters applied — npx prettier --check clean for both touched files.
• Tests added or updated for new or changed behavior — the existing shouldPatchCoredns test now uses the opts.isWsl override; a new test case pins the WSL2 branch.
• No secrets, API keys, or credentials committed.
• Doc pages updated for any user-facing behavior changes — N/A, the new opts argument is test-only API surface; production callers don't pass it.

Doc Changes

• N/A (no doc changes)

---

Signed-off-by: T Savo evilgenius@nefariousplan.com

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds an explicit opts.isWsl boolean override to isWsl() in bin/lib/platform.js, so callers can force WSL/non-WSL detection. Tests in test/platform.test.js were updated to split the previous host-ambiguous shouldPatchCoredns assertion into two deterministic cases covering { isWsl: false } and { isWsl: true }.

Changes

Cohort / File(s)	Summary
WSL Override Support bin/lib/platform.js	isWsl(opts = {}) now returns immediately when opts.isWsl is a boolean; existing environment-based detection remains for other cases.
Platform Test Coverage test/platform.test.js	Replaced a single host-dependent shouldPatchCoredns test with two explicit cases passing { isWsl: false } and { isWsl: true } to make assertions deterministic across hosts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I toggled WSL with a gentle hop,
Tests now pass and never stop,
One false, one true — no flake or fright,
The rabbit's patch makes CI bright ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding an isWsl override to the shouldPatchCoredns function for deterministic WSL2 testing.
Linked Issues check	✅ Passed	The PR implements objective 3 from issue #1621: allowing tests to pass an explicit isWsl option to override host detection and adding a WSL-specific test case.
Out of Scope Changes check	✅ Passed	All changes are scoped to implementing objective 3 from #1621. No modifications address objectives 1 or 2, and no unrelated changes are present.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR makes shouldPatchCoredns tests deterministic on WSL2 hosts by allowing callers to explicitly override WSL detection, avoiding reliance on host kernel introspection during unit tests.

Changes:

• Add an opts.isWsl boolean short-circuit to isWsl() so callers can bypass host detection when desired.
• Update shouldPatchCoredns tests to pass { isWsl: false } for non-WSL behavior and add a { isWsl: true } case to lock the WSL branch.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
bin/lib/platform.js	Adds an explicit opts.isWsl override to make WSL detection controllable by callers (primarily for deterministic tests).
test/platform.test.js	Pins shouldPatchCoredns behavior via { isWsl: ... } and adds coverage for the WSL path.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The test titles/descriptions imply they depend on the host being non-WSL/WSL2, but the behavior is actually pinned via the { isWsl: ... } override and should pass on any host. Consider renaming these to reflect the simulated condition (e.g., "when isWsl is false" / "when isWsl is true" or "on WSL" instead of "on WSL2") to avoid confusion for future maintainers running the suite on different environments.

[TSavo]

Force-pushed to add a Signed-off-by trailer (DCO compliance) — the diff itself is unchanged. CodeRabbit's prior review still applies to the same content.

Ready for a maintainer to approve workflow runs whenever you have a moment — first-time-contributor gate.

[cv]

LGTM — security review PASS.

• Override is unreachable in production (all callers pass no opts)
• Strict typeof === "boolean" guard prevents non-boolean values
• Consistent with existing dependency-injection pattern in platform.js
• Improves test coverage of the WSL2 branch

No concerns.

[TSavo]

Thanks for the merge and the explicit security review @cv — particularly noting the production-unreachability and the strict typeof === "boolean" guard. Glad the dependency-injection pattern in platform.js carried the day on the design choice.

For tracking: this is one of three test-environment fixes from #1621. The other two (#1627 cli timeout, #1628 install-preflight sysbin isolation) are still open and have actionable reviewer feedback I just addressed in fresh commits.