fix(cli): report skipped hidden directories during skill install#1856
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughcollectFiles() now records hidden directories with a trailing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
collectFiles() silently dropped dot-directories (e.g. .secret/) without adding them to skippedDotfiles. Users were warned about skipped dot-files but not about entire hidden directory trees being omitted. Now both dot-files and dot-directories are reported, with a trailing / to distinguish directories in the CLI output. Reported-by: brandonpelfrey Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
d64a19c to
f099346
Compare
## Summary - Document tier-based policy selector (Restricted/Balanced/Open) in commands, network policies, and customize-network-policy pages (from #1753) - Document configurable port overrides via environment variables (`NEMOCLAW_GATEWAY_PORT`, `NEMOCLAW_DASHBOARD_PORT`, `NEMOCLAW_VLLM_PORT`, `NEMOCLAW_OLLAMA_PORT`) (from #1645) - Document `nemoclaw <sandbox> skill install <path>` command (from #1845, #1856) - Document reserved sandbox name validation — CLI command collision check (from #1773) - Bump doc version switcher through 0.0.15 - Remove `--dangerously-skip-permissions` from onboard usage synopsis (docs-skip violation) - Regenerate agent skills from updated docs ## Test plan - [x] `make docs` builds without warnings - [x] All pre-commit hooks pass - [ ] Verify rendered pages in docs build output - [ ] Cross-references resolve correctly (`policy-tiers` anchor, `environment-variables` section) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…DIA#1856) ## Summary - `collectFiles()` silently dropped dot-directories (e.g. `.secret/`) without reporting them in `skippedDotfiles`. Users were warned about skipped dot-files but not about entire hidden directory trees being omitted. - Now both dot-files and dot-directories are reported, with a trailing `/` to distinguish directories in the CLI output (e.g. `Skipping 2 hidden path(s): .env, .secret/`). - Fixed misleading comment in `postInstall()` that said "shellQuote the relative part" when the code actually uses double-quoted interpolation (safe due to `validateRelativePath` charset restriction). Reported by @brandonpelfrey. ## Test plan - [x] Added regression test: hidden directory with nested files (`.secret/token.txt`) is now reported as `.secret/` in `skippedDotfiles` - [x] All 25 unit tests pass (`npx vitest run src/lib/skill-install.test.ts`) - [x] Pre-commit hooks pass (lint, commitlint, gitleaks) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Hidden directories and dot-prefixed files inside folders are now properly recorded and reported when skipped during skill installation. * Status messaging updated to display "hidden path(s)" instead of "dotfile(s)" for clearer upload feedback. * **Tests** * Added test coverage validating collection and reporting of non-hidden files and skipped hidden paths (directories and dot-prefixed files). <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com> Signed-off-by: ColinM-sys <cmcdonough@50words.com>
Summary
collectFiles()silently dropped dot-directories (e.g..secret/) without reporting them inskippedDotfiles. Users were warned about skipped dot-files but not about entire hidden directory trees being omitted./to distinguish directories in the CLI output (e.g.Skipping 2 hidden path(s): .env, .secret/).postInstall()that said "shellQuote the relative part" when the code actually uses double-quoted interpolation (safe due tovalidateRelativePathcharset restriction).Reported by @brandonpelfrey.
Test plan
.secret/token.txt) is now reported as.secret/inskippedDotfilesnpx vitest run src/lib/skill-install.test.ts)Summary by CodeRabbit
Bug Fixes
Tests