Skip to content

fix(onboard): replace false success log with setup deferred message in setupOpenclaw#189

Closed
dumko2001 wants to merge 1 commit intoNVIDIA:mainfrom
dumko2001:fix/c1-setupopenclaw-false-success
Closed

fix(onboard): replace false success log with setup deferred message in setupOpenclaw#189
dumko2001 wants to merge 1 commit intoNVIDIA:mainfrom
dumko2001:fix/c1-setupopenclaw-false-success

Conversation

@dumko2001
Copy link
Copy Markdown
Contributor

@dumko2001 dumko2001 commented Mar 17, 2026

Rationale

The "success" log was being displayed before the setup was actually complete, which could be misleading for users if the setup failed or was taking longer.

Changes

Replaced the premature success checkmark with an informative message indicating that the setup is deferred.

Verification Results

  • Automated Tests: Passed all 52 core tests via npm test.
  • Manual Audit: Verified that the message is displayed correctly during onboarding.
  • Security Review: Verified no sensitive data leaks and correct permission enforcement.

Summary by CodeRabbit

  • Bug Fixes
    • Improved messaging during the onboarding process to provide clearer and more accurate guidance for OpenClaw setup, including explicit instructions for completing post-connection configuration steps.

@wscurran wscurran added the bug Something isn't working label Mar 19, 2026
@cv
Copy link
Copy Markdown
Contributor

cv commented Mar 21, 2026

@dumko2001 — replacing a false success log with a deferred message is exactly the right call. Please rebase onto the latest main so we can review this in context. Lots has changed upstream.

@dumko2001 dumko2001 closed this Mar 21, 2026
@dumko2001 dumko2001 force-pushed the fix/c1-setupopenclaw-false-success branch from 4d8409e to 156c9a2 Compare March 21, 2026 21:16
@dumko2001 dumko2001 reopened this Mar 21, 2026
@github-actions
Copy link
Copy Markdown

This repository limits contributors to 10 open pull requests. Please close or merge existing PRs before opening new ones.

@github-actions github-actions bot closed this Mar 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6e31abe0-40d7-407e-a669-17aa8134519c

📥 Commits

Reviewing files that changed from the base of the PR and between 255e606 and bccae7c.

📒 Files selected for processing (1)
  • bin/lib/onboard.js

📝 Walkthrough

Walkthrough

The setupOpenclaw() function's logging output has been modified. Instead of confirming that the OpenClaw gateway is launched inside the sandbox, it now indicates that setup is deferred and instructs users to manually run openclaw nemoclaw launch after connecting.

Changes

Cohort / File(s) Summary
OpenClaw Setup Messaging
bin/lib/onboard.js
Updated setupOpenclaw() logging to reflect deferred launch behavior; removed "gateway launched" confirmation message and replaced with instructions for manual post-connect execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A message refined with a hop and a bound,
Where launch now awaits on firmer ground,
"Run it yourself!" the log gently cries,
No sandbox launch—just wise, deferred replies! 🌙

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

mafueee pushed a commit to mafueee/NemoClaw that referenced this pull request Mar 28, 2026
* restructure safty and policy section

* put the table autogeneration back

* enhance generate policy ref doc

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants