fix(eject): ensure sandbox is stopped before host state restoration#192
Closed
dumko2001 wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(eject): ensure sandbox is stopped before host state restoration#192dumko2001 wants to merge 1 commit intoNVIDIA:mainfrom
dumko2001 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
wscurran
added
the
enhancement: feature
Contributor
|
@dumko2001 stopping the sandbox before host state restoration during eject makes total sense. Rebase onto the latest main when you get a chance? We want to review this against the current eject flow. |
Contributor
Author
|
@cv the feature it was patching has been removed.fix: remove openclaw nemoclaw CLI commands, keep provider and slash command (#492) This commit completely deleted nemoclaw/src/commands/eject.ts along with almost all the other local CLI commands. guess it was a good run :). you can close this since it's redundant :( |
mafueee
pushed a commit
to mafueee/NemoClaw
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Modifying host state files while the sandbox is active can lead to race conditions or file corruption.
Changes
Added a mandatory sandbox stop check before proceeding with host-side .openclaw file restoration.
Verification Results
npm test.