test(cli): regression test for non-string gatewayName normalization#2112
Merged
test(cli): regression test for non-string gatewayName normalization#2112
Conversation
Verifies that a numeric gatewayName in session metadata is replaced with the default "nemoclaw" during normalization. Closes #1286
3 tasks
Contributor
📝 WalkthroughWalkthroughA new test case was added to verify that non-string Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gatewayNamein session metadata is normalized to the default"nemoclaw"stringSupersedes #1286 — the code fix landed in #2082 via
parseSessionMetadata/readString; this PR carries forward the regression test.Credit
Test authored by @latenighthackathon in #1286. Their other merged contributions to NemoClaw include #1125, #1133, #1137, #1220, #1302, #1358, #1392, #1597, #1602, #1772, #1773, #1774, #1846.
Test plan
npx vitest run src/lib/onboard-session.test.ts— all 21 tests pass🤖 Generated with Claude Code