Skip to content

fix: install Node.js 22 (not 24) in install.sh#218

Closed
brianwtaylor wants to merge 1 commit intoNVIDIA:mainfrom
brianwtaylor:fix/node-version-mismatch
Closed

fix: install Node.js 22 (not 24) in install.sh#218
brianwtaylor wants to merge 1 commit intoNVIDIA:mainfrom
brianwtaylor:fix/node-version-mismatch

Conversation

@brianwtaylor
Copy link
Copy Markdown
Contributor

@brianwtaylor brianwtaylor commented Mar 17, 2026

Summary

  • Line 116 hardcodes nvm install 24 but RECOMMENDED_NODE_MAJOR=22 (line 20)
  • scripts/install.sh correctly installs 22; this mismatch causes nemoclaw to vanish from PATH when nvm default is reset
  • Use ${RECOMMENDED_NODE_MAJOR} variable instead of hardcoded version

Fixes #162

Test plan

Automated Tests

npm test

Manual Testing

  • Run bash install.sh on a system without Node.js
  • Verify Node.js 22.x is installed (not 24)
  • Verify nemoclaw is on PATH after installation

@brianwtaylor
Copy link
Copy Markdown
Contributor Author

Closing — this was independently fixed in 90c5dec (#167), which landed on main while this PR was open. Same change, same issue.

mafueee pushed a commit to mafueee/NemoClaw that referenced this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install.sh installs Node 24 but scripts/install.sh resets nvm default to Node 22

1 participant