fix: const-to-let for currentPolicy reassignment#232
Merged
dnandakumar-nv merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
currentPolicy was declared const but reassigned when prepending a version field to policies missing one. This throws TypeError at runtime for sandboxes with existing policies that lack a version field. Spotted by @dnandakumar-nv in #49.
dnandakumar-nv
approved these changes
Mar 17, 2026
Ryuketsukami
pushed a commit
to Ryuketsukami/NemoClaw
that referenced
this pull request
Mar 24, 2026
…or (NVIDIA#232) currentPolicy was declared const but reassigned when prepending a version field to policies missing one. This throws TypeError at runtime for sandboxes with existing policies that lack a version field. Spotted by @dnandakumar-nv in NVIDIA#49.
jessesanford
pushed a commit
to jessesanford/NemoClaw
that referenced
this pull request
Mar 24, 2026
…or (NVIDIA#232) currentPolicy was declared const but reassigned when prepending a version field to policies missing one. This throws TypeError at runtime for sandboxes with existing policies that lack a version field. Spotted by @dnandakumar-nv in NVIDIA#49.
mafueee
pushed a commit
to mafueee/NemoClaw
that referenced
this pull request
Mar 28, 2026
* fix(cli): improve completion coverage and gateway selection Closes NVIDIA#232 Add typed completion metadata for gateway, sandbox, and path arguments, make gateway selection interactive on TTYs, and expose root subcommands in completions while keeping non-interactive behavior stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Assignment to constant variablewhenapplyPreset()encounters a sandbox with an existing policy that has noversion:fieldcurrentPolicywas declaredconstbut conditionally reassigned on the branch that prependsversion: 1\n. Changing toletfixes the crash.Spotted by @dnandakumar-nv in #49 (comment).
Test plan