Skip to content

[fix] Fix logger reference in quantization.py #8144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koush wants to merge 2 commits into from
+1 −1
Closed

[fix] Fix logger reference in quantization.py #8144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3417f9d
[fix] Fix logger reference in quantization.py
koush Oct 4, 2025
a372e2b
Replace logger with trtllm_logger in quantization.py
koush Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorrt_llm/_torch/modules/fused_moe/quantization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,7 +1614,7 @@ def load_all_fp4_weight_scales_and_alphas(
expert_idx = local_slot_id

if not torch.allclose(w1_weight_scale_2, w3_weight_scale_2):
logger.warning(
trtllm_logger.logger.warning(
Copy link
Copy Markdown
Collaborator

@karljang karljang Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7993 fixed the issue by changing the import name 😄

f"w1_weight_scale_2 != w3_weight_scale_2 ({w1_weight_scale_2} != {w3_weight_scale_2}), selecting the larger value. Accuracy may be affected."
)
w1_weight_scale_2 = torch.max(w1_weight_scale_2,
Expand Down