Merged
Conversation
Member
|
@erhoo82 Please sign your commits (please refer to CONTRIBUTING.rst to see how to do this). |
add env knob to enable async amax reduction Signed-off-by: slym <slym@login-preos01.a51.clusters.nvidia.com>
09ad800 to
5e5ec4c
Compare
Collaborator
Author
|
Thanks, signed the commit. |
timmoon10
reviewed
Mar 28, 2023
Collaborator
|
/te-ci |
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Collaborator
|
/te-ci |
ksivaman
reviewed
Apr 3, 2023
ksivaman
reviewed
Apr 3, 2023
Signed-off-by: slym <slym@login-preos01.a51.clusters.nvidia.com>
56f25a4 to
2699fb9
Compare
Signed-off-by: slym <slym@login-preos01.a51.clusters.nvidia.com>
Collaborator
Author
|
@ksivaman |
ksivaman
reviewed
Apr 4, 2023
ksivaman
reviewed
Apr 4, 2023
ksivaman
reviewed
Apr 4, 2023
ksivaman
reviewed
Apr 4, 2023
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Member
|
/te-ci |
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Member
|
/te-ci |
1 similar comment
Member
|
/te-ci |
Closed
Contributor
|
Hello, @ksivaman @erhoo82 , I think it's more reasonable to put TransformerEngine/transformer_engine/pytorch/module/base.py Lines 582 to 616 in b8ba734 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVTE_ASYNC_AMAX_REDUCTION)