Skip to content

[PyTorch] Set flags in norm modules for Mcore sequence-parallel support#1528

Merged
timmoon10 merged 1 commit intoNVIDIA:mainfrom
timmoon10:norm-sequence-parallel-flag
Mar 1, 2025
Merged

[PyTorch] Set flags in norm modules for Mcore sequence-parallel support#1528
timmoon10 merged 1 commit intoNVIDIA:mainfrom
timmoon10:norm-sequence-parallel-flag

Conversation

@timmoon10
Copy link
Collaborator

Description

#1033 introduced a bug with Mcore integration: the LayerNorm or RMSNorm modules might not set the sequence_parallel attr in its params, which is used in Mcore sequence parallelism.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Set flags in norm modules for Mcore sequence-parallel support

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added the bug Something isn't working label Feb 28, 2025
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch L0 L1

@timmoon10 timmoon10 merged commit 4b523d2 into NVIDIA:main Mar 1, 2025
12 checks passed
@timmoon10 timmoon10 deleted the norm-sequence-parallel-flag branch March 1, 2025 00:29
ptrendx pushed a commit that referenced this pull request Mar 1, 2025
…rt (#1528)

Set flag in norm modules for Mcore sequence-parallel support

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants