[PyTorch] Set flags in norm modules for Mcore sequence-parallel support#1528
Merged
timmoon10 merged 1 commit intoNVIDIA:mainfrom Mar 1, 2025
Merged
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Collaborator
Author
|
/te-ci pytorch L0 L1 |
ptrendx
approved these changes
Feb 28, 2025
ptrendx
pushed a commit
that referenced
this pull request
Mar 1, 2025
…rt (#1528) Set flag in norm modules for Mcore sequence-parallel support Signed-off-by: Tim Moon <tmoon@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1033 introduced a bug with Mcore integration: the LayerNorm or RMSNorm modules might not set the
sequence_parallelattr in its params, which is used in Mcore sequence parallelism.Type of change
Changes
Checklist: