[JAX] grouped_gemm() uses variadic arguments#1658
Merged
phu0ngng merged 14 commits intoNVIDIA:mainfrom Apr 14, 2025
Merged
Conversation
d9b9aef to
600029a
Compare
phu0ngng
reviewed
Apr 10, 2025
600029a to
3af8804
Compare
Collaborator
|
/te-ci jax L0 |
5d581ee to
292f7a9
Compare
phu0ngng
reviewed
Apr 10, 2025
phu0ngng
reviewed
Apr 10, 2025
phu0ngng
reviewed
Apr 10, 2025
Signed-off-by: Hua Huang <huah@nvidia.com>
Signed-off-by: Hua Huang <huah@nvidia.com>
Signed-off-by: Hua Huang <huah@nvidia.com>
Signed-off-by: Hua Huang <huah@nvidia.com>
Signed-off-by: Hua Huang <huah@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Hua Huang <huah@nvidia.com>
Signed-off-by: Hua Huang <huah@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Hua Huang <huah@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Hua Huang <huah@nvidia.com>
292f7a9 to
c850c00
Compare
Collaborator
|
/te-ci jax L0 |
Collaborator
|
Pipeline #26823920 passed. |
phu0ngng
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the
grouped_gemm()implementation in JAX. The original implementation manually flattens all input matrices before lowering to C++ function and manually split the output into a list of tensors. Using variadic arguments allows the code to avoid extra copying of inputs and outputs.This PR is marked as a draft since PR #1545 breaks both the original implementation and this implementation for MXFP8 on Blackwell.Fixed by PR #1652.Type of change
Changes
Rewrite
grouped_gemm()andGroupedGemmPrimitiveusing variadic arguments.Checklist: