Fix minimum version of cublas for grouped gemm#2631
Merged
pggPL merged 6 commits intoNVIDIA:mainfrom Jan 30, 2026
Merged
Conversation
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Collaborator
Author
|
/te-ci |
Contributor
Greptile OverviewGreptile SummaryThis PR corrects the minimum cuBLAS version requirement for grouped GEMM from 13.1.0 to 13.2.0, fixing build failures introduced in PR #2502. Changes:
Issue Found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User Code
participant API as nvte_grouped_gemm
participant Check as Version Check
participant cuBLAS as cuBLAS 13.2+
User->>API: Call nvte_grouped_gemm()
API->>Check: Verify CUBLAS_VERSION >= 130200
alt Compile-time check fails
Check-->>User: Error: Requires cuBLAS 13.2+
else Compile-time check passes
API->>Check: Verify runtime cublas_version() >= 130200
alt Runtime check fails
Check-->>User: Error: Runtime cuBLAS too old
else Runtime check passes
API->>Check: Verify SM arch >= 100 (Blackwell)
alt Architecture check fails
Check-->>User: Error: Requires Blackwell or newer
else All checks pass
API->>cuBLAS: Execute grouped GEMM
cuBLAS-->>API: Result
API-->>User: Success
end
end
end
|
Collaborator
Author
|
/te-ci jax L0 |
Collaborator
Author
|
/te-ci pytorch |
zhongbozhu
reviewed
Jan 29, 2026
| NVTE_CHECK(transformer_engine::cuda::sm_arch(current_device) >= 100, | ||
| "nvte_grouped_gemm requires Blackwell (SM100) or newer architecture."); | ||
| NVTE_CHECK(cuda::cublas_version() >= 130200, | ||
| NVTE_CHECK(transformer_engine::cuda::cublas_version() >= 130200, |
Collaborator
There was a problem hiding this comment.
shouldn't there be more than one places to add this transformer_engine::?
Collaborator
Author
|
/te-ci |
1 similar comment
Collaborator
Author
|
/te-ci |
| cudaStream_t stream) { | ||
| NVTE_ERROR("nvte_grouped_gemm requires cuBLAS 13.1+, but compile-time cuBLAS version is ", | ||
| NVTE_ERROR("nvte_grouped_gemm requires cuBLAS 13.2+, but compile-time cuBLAS version is ", | ||
| CUBLAS_VERSION, ". Please upgrade to CUDA 13.1 or newer."); |
Contributor
There was a problem hiding this comment.
error message says "upgrade to CUDA 13.1 or newer" but should say "CUDA 13.2 or newer" to match the cuBLAS 13.2+ requirement
Suggested change
| CUBLAS_VERSION, ". Please upgrade to CUDA 13.1 or newer."); | |
| CUBLAS_VERSION, ". Please upgrade to CUDA 13.2 or newer."); |
ptrendx
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes build issue introduced with #2502 - that PR had incorrect minimal version of cublas and it results in build fails on some containers.
Type of change
Checklist: