Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
|
/te-ci |
|
/te-ci |
|
We would have to also change to the correct includes for the cpptests |
Use Google style for header includes. Signed-off-by: Tim Moon <tmoon@nvidia.com>
|
/te-ci |
Incorporating changes from NVIDIA#389. Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jan Bielak <jbielak@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com>
Hack to get around macro redefinition warning. Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
|
/te-ci |
|
Why not reuse logging across the FWs? |
|
As I see it,
Currently (1) and (2) are combined together in This PR makes
I think (1) is the right answer, but it's more complicated. (2) and (3) are simple, but have some iffiness. I don't like (4). EDIT: Looking at #393, (4) doesn't seem as bad. The CUDA utilities are sufficiently complicated to make reimplementing a bad idea. I think the main difference is how the headers are called. |
Signed-off-by: Tim Moon <tmoon@nvidia.com>
|
/te-ci |
|
I would probably prefer changing current |
Should we handle that now or in a future PR? That would significantly increase the scope of this refactor since we would need to change the build system to build the "common" library separately from the "core" library. I think there's value in improving the logging quickly. |
Signed-off-by: Tim Moon <tmoon@nvidia.com>
|
/te-ci |
|
/te-ci |
ptrendx
left a comment
There was a problem hiding this comment.
Please rebase to the current main.
Signed-off-by: Tim Moon <tmoon@nvidia.com>
|
/te-ci |
Changes:
commonand each of the frameworks (I'm open to suggestion on this design).commonto use the string utility functions and to improve the error messages (see check_cublas file and line is not helpful #376).The refactored logging macros are backward compatible, but it's now easier to make descriptive error messages. For example, consider:
TransformerEngine/transformer_engine/common/transpose/transpose.cu
Line 130 in cbfb8c6
We can now do something like:
NVTE_CHECK(input.data.shape.size() == 2, "Input must have 2 dimensions, ", "but found ", input.data.shape.size(), ".");Closes #376.