Use arguments instead of env vars for TP comm overlap#649
Merged
timmoon10 merged 4 commits intoNVIDIA:mainfrom Feb 14, 2024
Merged
Use arguments instead of env vars for TP comm overlap#649timmoon10 merged 4 commits intoNVIDIA:mainfrom
timmoon10 merged 4 commits intoNVIDIA:mainfrom
Conversation
ksivaman
reviewed
Jan 31, 2024
Comment on lines
196
to
207
Member
There was a problem hiding this comment.
Suggested change
| ub_tp_comm_overlap : bool, default = `False` | |
| if set to `True`, enables overlap of TP communication with computation. | |
| ub_bulk_wgrad : bool, default = `True` | |
| ub_bulk_dgrad : bool, default = `True` | |
| ub_split_ag : bool, default = `True` | |
| enables split-pipelined overlap of allgather with computation. | |
| ub_split_rs : bool, default = `True` | |
| enables split-pipelined overlap of reduce-scatter with computation. | |
| ub_atomic_gemm_ag: bool, default = `False` | |
| if set to `True`, enables atomic overlap of allgather with computation. | |
| ub_atomic_gemm_rs: bool, default = `False` | |
| if set to `True`, enables atomic overlap of reduce-scatter with computation. |
Collaborator
There was a problem hiding this comment.
@ksivaman Why did we want to remove this documentation? To remove clutter?
8 tasks
Member
|
Could you sign off your commits as per this guide? @minitu |
minitu
force-pushed
the
jaeminc/tp_comm_knobs_pr
branch
from
7d93d29 to
d30d93b
Compare
minitu
force-pushed
the
jaeminc/tp_comm_knobs_pr
branch
from
e0f60a7 to
86fd020
Compare
minitu
commented
Feb 5, 2024
Collaborator
|
/te-ci pytorch |
added 4 commits
February 13, 2024 12:29
Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
Signed-off-by: Jaemin Choi <jaeminc@nvidia.com>
minitu
force-pushed
the
jaeminc/tp_comm_knobs_pr
branch
from
e991228 to
7c989ae
Compare
Contributor
Author
|
Rebased to ToT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.