[PyTorch] Handle non-constant FP8 scales in ONNX export#861
Closed
timmoon10 wants to merge 1 commit intoNVIDIA:mainfrom
Closed
[PyTorch] Handle non-constant FP8 scales in ONNX export#861timmoon10 wants to merge 1 commit intoNVIDIA:mainfrom
timmoon10 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Collaborator
Author
|
/te-ci pytorch |
Collaborator
Author
|
Looking more closely, I was a little too pessimistic in my investigation of ONNX exporting. ONNX export does appear to work correctly if the FP8 scales are initialized outside of the export process and it can correctly convert FP8 scale buffers to Constant operations. The issue I saw in #820 was because we copy an FP8 scale with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ONNX export currently assumes that FP8 scales can be represented with constant operations, which requires that scales are initialized during the export process. However, we expect that the scales are initialized and updated during training. This PR uses slice operations to access the correct FP8 scales.
These changes are also included in #820.
Type of change
Changes
Checklist: