chore(recipe): bump dynamo-platform from 0.9.x to 1.0.1#459
Open
Jont828 wants to merge 6 commits intoNVIDIA:mainfrom
Open
chore(recipe): bump dynamo-platform from 0.9.x to 1.0.1#459Jont828 wants to merge 6 commits intoNVIDIA:mainfrom
Jont828 wants to merge 6 commits intoNVIDIA:mainfrom
Conversation
Upgrade Dynamo platform to the latest 1.0.1 release across registry and all inference overlay recipes. Key changes for the 1.0 schema: - Registry: defaultVersion 0.9.1 → 1.0.1 - Overlays: all 5 dynamo overlays updated from 0.9.0 → 1.0.1 - Values: rewritten for 1.0 Helm schema (global.* subchart controls, upgradeCRD: true, removed stale image pins and kube-rbac-proxy workaround fixed upstream) Signed-off-by: Jont828 <jt572@cornell.edu>
Collaborator
|
/ok to test 852739e |
Contributor
Author
|
@dims Merged changes from main, can we get another CI run? |
Collaborator
yuanchen8911
reviewed
Apr 2, 2026
Contributor
Cross-Review Summary for PR #459Reviewers: Claude Code, Codex, CodeRabbit + Integration Analysis Confirmed Issues
Open Questions
Positive Observations
Cross-review by Claude Code + Codex + CodeRabbit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recipes/components/dynamo-platform/values.yamlfor the 1.0 Helm schema:global.*subchart controls,upgradeCRD: true, removed stale image pin and kube-rbac-proxy workaround (fixed upstream)dynamo-crdsversion intentionally unchanged (no 1.0 CRD chart exists; platform chart now bundles CRDs viaupgradeCRD)Test plan
go test -race ./pkg/recipe/... -count=1— passesgo test -race ./pkg/bundler/... -count=1— passesmake test— all tests pass, coverage 72%+make lint(golangci-lint + yamllint on changed files) — cleanmake kwok-e2e RECIPE=h100-eks-ubuntu-inference-dynamo)dynamo-platform1.0.1 chart renders correctly withglobal.*keys🤖 Generated with Claude Code