fix(ci): add -mod=vendor to snapshot agent build#534
Merged
mchmarny merged 1 commit intoNVIDIA:mainfrom Apr 10, 2026
Merged
Conversation
The 'Build snapshot agent' step in aicr-build was missing GOFLAGS=-mod=vendor, unlike the other two build steps. On cold CI runners without a Go module cache, this caused 'go build' to silently download all dependencies from the network, hanging until the job timeout. Bug introduced in NVIDIA#290 (container-per-validator engine), latent until runners lost their warm caches. Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. Verified that the "Build snapshot agent" step was the only one of three 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
mchmarny
approved these changes
Apr 10, 2026
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
GOFLAGS: -mod=vendorto the "Build snapshot agent" step inaicr-buildaction, matching the other two build steps.Motivation / Context
GPU CI tests (training, conformance) fail consistently on cold runners because
go buildin the snapshot agent step downloads all dependencies from the network instead of using vendored sources. This causes the build to hang silently until the 45-minute job timeout.Fixes: N/A
Related: #290 (introduced the bug), #505 (similar CI build fix)
Type of Change
Component(s) Affected
.github/actions/aicr-build/action.ymlImplementation Notes
The "Build snapshot agent" step was the only build step missing
GOFLAGS: -mod=vendor. The "Build validator images" and "Build aicr binary" steps already had it. On warm runners (cached Go modules) the missing flag was harmless; on cold runners it causedgo buildto silently fetch all deps, exhausting the job timeout.Note: The
go runcalls in the GPU workflow files (gpu-h100-conformance-test.yaml#L154,gpu-h100-training-test.yaml#L153,gpu-h100-inference-test.yaml#L270) also lack an explicit-mod=vendor, but these are not the same bug. With Go 1.26 and avendor/directory present,go rundefaults to vendor mode automatically. Adding explicit flags there would be a consistency hardening follow-up, not a bug fix.Testing
One-line CI-only change. Verified by inspecting the action file — the fix makes the snapshot agent step consistent with the other two build steps. Cherry-picked onto PR #523 to validate on GPU runners.
Risk Assessment
Rollout notes: N/A
Checklist
make testwith-race)make lint)git commit -S)