Skip to content

Comments

Fix gradient accumulation for cuDNN convolution layer#50

Merged
lukeyeager merged 1 commit intoNVIDIA:masterfrom
slayton58:convolution-accumulate-fix
Nov 3, 2015
Merged

Fix gradient accumulation for cuDNN convolution layer#50
lukeyeager merged 1 commit intoNVIDIA:masterfrom
slayton58:convolution-accumulate-fix

Conversation

@slayton58
Copy link

Fixes the gradient accumulation issue in CuDNNConvolutionLayer reported in caffe BVLC/pull/3254

@lukeyeager
Copy link
Member

Why not just cherry-pick @ronghanghu's commit? Commenting rather than deleting those lines may lead to a merge conflict down the road.

Also, why did you change the test if it wasn't needed in BVLC/pull/3254?

@lukeyeager lukeyeager added the bug label Oct 28, 2015
@slayton58
Copy link
Author

I changed the gradient file to match what is in bvlc today, and without it the convolution tests fail

On Oct 28, 2015, at 4:17 PM, Luke Yeager notifications@github.com wrote:

Why not just cherry-pick @ronghanghu's commit? Commenting rather than deleting those lines may lead to a merge conflict down the road.

Also, why did you change the test if it wasn't needed in BVLC#3254?


Reply to this email directly or view it on GitHub.

@lukeyeager
Copy link
Member

Oh sorry, I didn't notice this was for the master branch. I wish @github would make that a little more obvious somehow.

So we need this fix in the caffe-0.14 branch, too?

lukeyeager added a commit that referenced this pull request Nov 3, 2015
Fix gradient accumulation for cuDNN convolution layer
@lukeyeager lukeyeager merged commit 3baf1af into NVIDIA:master Nov 3, 2015
@lukeyeager
Copy link
Member

Merged into master and caffe-0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants