[BACKPORT]: Ensure that headers in <cuda/*> can be build with a C++ only compiler (#3472)#3651
Merged
miscco merged 3 commits intoNVIDIA:branch/2.8.xfrom Feb 3, 2025
Merged
Conversation
bernhardmgruber
approved these changes
Feb 3, 2025
Contributor
🟩 CI finished in 1h 03m: Pass: 100%/169 | Total: 1d 02h | Avg: 9m 15s | Max: 38m 14s | Hits: 557%/20825
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 169)
| # | Runner |
|---|---|
| 125 | linux-amd64-cpu16 |
| 14 | windows-amd64-cpu16 |
| 10 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
Contributor
🟩 CI finished in 40m 54s: Pass: 100%/169 | Total: 1d 01h | Avg: 9m 03s | Max: 38m 31s | Hits: 558%/20825
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 169)
| # | Runner |
|---|---|
| 125 | linux-amd64-cpu16 |
| 14 | windows-amd64-cpu16 |
| 10 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
miscco
commented
Feb 3, 2025
| _CCCL_HOST_DEVICE constexpr uint32_t __ap_floor_log2(uint32_t __x) | ||
| { | ||
| return (__x == 1 | __x == 0) ? 0 : 1 + __ap_floor_log2(__x >> 1); | ||
| return ((__x == 1) || (__x == 0)) ? 0 : 1 + __ap_floor_log2(__x >> 1); |
Contributor
Author
There was a problem hiding this comment.
NOTE: MSVC was warning about those lines and I believe the && is much clearer given that we are dealing with booleans
ericniebler
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #3472 to ensure that we can use stream_ref with a host compiler