Fix calculation of necessary bits in feistel projection #7098
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We incorrectly used `bit_ceil` which gave us the next power of two not the number of bits we need to represent the number of elements. Use `bit_width` instead Fixes NVIDIA#7073
RAMitchell
approved these changes
Jan 7, 2026
bernhardmgruber
approved these changes
Jan 7, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 16h 58m: Pass: 100%/91 | Total: 20h 33m | Max: 47m 29s | Hits: 98%/218937See results here. |
Contributor
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We incorrectly used
bit_ceilwhich gave us the next power of two not the number of bits we need to represent the number of elements. Usebit_widthinsteadFixes #7073