Add trait for is_bitwise_comparable#83
Merged
jrhemstad merged 4 commits intoNVIDIA:devfrom Jun 2, 2021
Merged
Conversation
rapids-bot Bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jun 3, 2021
#1640) Dependent on NVIDIA/cuCollections#83 Authors: - Seunghwa Kang (https://github.com/seunghwak) Approvers: - Brad Rees (https://github.com/BradReesWork) - Chuck Hastings (https://github.com/ChuckHastings) - Rick Ratzel (https://github.com/rlratzel) URL: #1640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I changed it so the only supported Key/Value types were ones where
has_unique_object_representations_v<T>was true. However, this disallows any floating point types, which is too restrictive for many valid use cases.Therefore, I added a trait,
cuco::is_bitwise_comparablethat allows for user-defined specializations to declare that a typeTis safe for bitwise comparison.