Add CMake build #15
Merged
Add CMake build #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a CMake-enabled build process for cuDecomp.
While the existing Makefile and configuration file method is fairly flexible, it can be complicated for some users to track down and set dependencies. While I initially tried to retain some simplicity through defining a generic
nvhpcsdk.confthat would work out of the box with a default NVIDIA HPC SDK installation, recent path changes to libraries in the SDK (e.g., HPCX being CUDA-versioned) make this no longer possible.The automated dependency discovery from CMake makes these path inconsistency issues irrelevant and should make cuDecomp easier to build for users across systems going forward.