Skip to content

Fix integer overflow issue in Fortran poisson example. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romerojosh merged 1 commit into from
Feb 20, 2025
Merged

Fix integer overflow issue in Fortran poisson example. #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/fortran/poisson/poisson.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ program main
integer :: il, jl, ig, jg
integer :: offsets(3), xoff, yoff
integer :: np(3)
integer(8) :: norm
np(piZ%order(1)) = piZ%shape(1)
np(piZ%order(2)) = piZ%shape(2)
np(piZ%order(3)) = piZ%shape(3)
Expand All @@ -323,6 +324,8 @@ program main

! divide by -K**2, and normalize

norm = int(nx,8) * int(ny,8) * int(nz,8)

offsets(piZ%order(1)) = piZ%lo(1) - 1
offsets(piZ%order(2)) = piZ%lo(2) - 1
offsets(piZ%order(3)) = piZ%lo(3) - 1
Expand All @@ -338,7 +341,7 @@ program main
ig = xoff + il
do k = 1, nz
k2 = kx_d(ig)**2 + ky_d(jg)**2 + kz_d(k)**2
phi3d(k,il,jl) = -phi3d(k,il,jl)/k2/(nx*ny*nz)
phi3d(k,il,jl) = -phi3d(k,il,jl)/k2/norm
enddo
enddo
enddo
Expand Down