Skip to content

chore(deps): bump precommit versions #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kkraus14 merged 3 commits into from
Sep 30, 2025
Merged

chore(deps): bump precommit versions #1017

kkraus14 merged 3 commits into from
Sep 30, 2025

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Sep 25, 2025

Run autoupdate freeze on pre-commit and autofixed the lints produced by a newer version of ruff.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 25, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud cpcloud changed the title bump precommit versions chore(deps): bump precommit versions Sep 25, 2025
@leofang
Copy link
Member

leofang commented Sep 25, 2025

The new grouping of import statements is very annoying, we have been grouping the imports following PEP 8 just fine and it's now broken. Can we please just skip whatever new rule is implemented in Ruff?

@leofang leofang requested a review from rwgk September 25, 2025 14:45
@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 25, 2025

Broken feels a bit extreme--the code still runs--but that's fine by me. PEP8 is probably not something we should religiously follow FWIW, it has its problems.

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 25, 2025

In any case, I'll revert those changes.

@cpcloud
Copy link
Contributor Author

cpcloud commented Sep 25, 2025

@leofang I think the import modifications are correct actually. Notice that not every file is formatted, so this is just bringing various other files in line with the rest of the codebase.

kkraus14
kkraus14 reviewed Sep 25, 2025
View reviewed changes
@cpcloud cpcloud force-pushed the bump-precommit-versions branch 3 times, most recently from 2606cdc to 0059cca Compare September 29, 2025 17:03
@cpcloud cpcloud requested a review from kkraus14 September 29, 2025 17:03
kkraus14
kkraus14 reviewed Sep 29, 2025
View reviewed changes
@cpcloud cpcloud force-pushed the bump-precommit-versions branch from 0059cca to 69217c2 Compare September 29, 2025 19:55
@rwgk
Copy link
Collaborator

rwgk commented Sep 30, 2025

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@kkraus14 kkraus14 merged commit 6f900d7 into NVIDIA:main Sep 30, 2025
70 checks passed
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang added this to the cuda.core beta 7 milestone Oct 9, 2025
@leofang leofang added enhancement Any code-related improvements support All things related to the project that can't be categorized labels Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@cpcloud cpcloud

Labels

enhancement Any code-related improvements support All things related to the project that can't be categorized

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

4 participants

@cpcloud @leofang @rwgk @kkraus14