Skip to content

Un-disable ruff E722 Do not use bare except #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkraus14 merged 3 commits into from
Dec 10, 2025
Merged

Un-disable ruff E722 Do not use bare except #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a24743
Remove `E722` from `[lint.per-file-ignores]` in ruff.toml
rwgk Dec 9, 2025
1990d77
Replace bare except → cufile.cuFileError
rwgk Dec 9, 2025
12b4714
cuda_bindings/examples/3_CUDA_Features/simpleCudaGraphs_test.py: remo…
rwgk Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions cuda_bindings/examples/3_CUDA_Features/simpleCudaGraphs_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import random as rnd

import numpy as np
import pytest
from common import common
from common.helper_cuda import checkCudaErrors, findCudaDevice
from cuda.bindings import driver as cuda
Expand Down Expand Up @@ -362,23 +361,6 @@ def cudaGraphsUsingStreamCapture(inputVec_h, inputVec_d, outputVec_d, result_d,
checkCudaErrors(cudart.cudaStreamDestroy(streamForGraph))


def checkKernelCompiles():
kernel_headers = """\
#include <cooperative_groups.h>
"""
try:
common.KernelHelper(kernel_headers, findCudaDevice())
except:
# Filters out test from automation when CG header has issues compiling
# Automation issue is observed when CG headers are obtained through PYPI packages
# The problem is that these headers and their dependencies are segmented between
# multiple packages, and NVRTC requires that you specify the path to each segemented
# include path.
return False
return True


@pytest.mark.skipif(not checkKernelCompiles(), reason="Automation filter against incompatible kernel")
def main():
size = 1 << 24 # number of elements to reduce
maxBlocks = 512
Expand Down
2 changes: 1 addition & 1 deletion cuda_bindings/tests/test_cufile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,7 @@ def test_param(param, val, default_val):
try:
# Currently this line will raise, see below.
cufile.set_parameter_string(param, int(ctypes.addressof(orig_val_buf)))
except:
except cufile.cuFileError:
# This block will always be reached because cuFILE could start with garbage default (empty string)
# that cannot be restored. In other words, cuFILE does honor the common sense that getter/setter
# should be round-tripable.
Expand Down
3 changes: 0 additions & 3 deletions ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,16 @@ exclude = ["**/_version.py"]
"setup.py" = ["F401"]

"cuda_bindings/examples/**" = [
"E722",
"E501", # line too long
]

"cuda_bindings/tests/**" = [
"E722",
"UP022",
"E402", # module level import not at top of file
"F841",
] # F841 complains about unused variables, but some assignments have side-effects that could be useful for tests (func calls for example)

"cuda_bindings/benchmarks/**" = [
"E722",
"UP022",
"E402", # module level import not at top of file
"F841",
Expand Down
Loading