Skip to content

Fix #1417: Fix test for Numpy 2.4.0 #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leofang merged 2 commits into from
Dec 22, 2025
Merged

Fix #1417: Fix test for Numpy 2.4.0 #1418

leofang merged 2 commits into from
Dec 22, 2025
+1 −4

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Dec 22, 2025 •
edited
Loading

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 22, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom mdboom self-assigned this Dec 22, 2025
@mdboom
Copy link
Contributor Author

mdboom commented Dec 22, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Dec 22, 2025

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@leofang leofang linked an issue Dec 22, 2025 that may be closed by this pull request
[BUG]: Numpy 2.4.0 breaks 6 cuda.core tests #1417
Closed
1 task
@leofang leofang added P0 High priority - Must do! test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Dec 22, 2025
@leofang leofang added this to the cuda.core beta 11 milestone Dec 22, 2025
leofang
leofang approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mike! It is an unfortunate decision in DLPack (dmlc/dlpack#177) that propagated to NumPy (numpy/numpy#29872). I did not have a chance to intervene before the decision went out.

@leofang leofang merged commit 46470ca into NVIDIA:main Dec 22, 2025
158 of 160 checks passed
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

@rwgk rwgk mentioned this pull request Jan 13, 2026
Open
github-actions bot pushed a commit that referenced this pull request Jan 13, 2026
@mdboom @github-actions
Fix #1417: Fix test for Numpy 2.4.0 (#1418)
1ab529a 
* Fix #1417: Fix test for Numpy 2.4.0

* Slightly improve logic

(cherry picked from commit 46470ca)
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Successfully created backport PR for release/cuda-core-v0.5.1:

@github-actions github-actions bot mentioned this pull request Jan 13, 2026
Merged
cpcloud pushed a commit that referenced this pull request Jan 13, 2026
@github-actions @mdboom
Fix #1417: Fix test for Numpy 2.4.0 (#1418) (#1476)
e0a11ef 
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
Fix #1417: Fix test for Numpy 2.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofang leofang leofang approved these changes

Assignees

@mdboom mdboom

Labels

cuda.core Everything related to the cuda.core module P0 High priority - Must do! test Improvements or additions to tests

Projects

None yet

Milestone

cuda.core beta 12

Development

Successfully merging this pull request may close these issues.

[BUG]: Numpy 2.4.0 breaks 6 cuda.core tests

2 participants

@mdboom @leofang