feat: allow constructing SMV from numpy arrays #1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cpcloud
force-pushed
the
add-from-array-interface
branch
from
dd893ce to
b140ed6
Compare
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
cpcloud
force-pushed
the
add-from-array-interface
branch
from
b140ed6 to
9d88940
Compare
Contributor
Author
|
/ok to test |
mdboom
requested changes
Jan 6, 2026
Contributor
Author
|
/ok to test |
1 similar comment
Contributor
Author
|
/ok to test |
mdboom
approved these changes
Jan 6, 2026
cpcloud
force-pushed
the
add-from-array-interface
branch
from
b7f7313 to
a87b279
Compare
Contributor
Author
|
/ok to test |
|
Member
|
Ideally we want to always use |
Contributor
Author
|
Yes, structured arrays, strings, bytes, and whatever other things DLPack doesn't support. |
Member
|
Ah right, thx for reminder... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the
StridedMemoryView.from_array_interface()class method to supportcreating memory views from objects implementing the NumPy Array Interface
protocol (
__array_interface__).Changes
New API (
cuda_core/cuda/core/_memoryview.pyx:156-163)StridedMemoryView.from_array_interface(obj)classmethod for creatingmemory views from array interface objects
view_as_array_interface()helper function that:shape,dtype,strides, andreadonlyflag from__array_interface__dictTest Coverage (
cuda_core/tests/test_utils.py:464-515)Note: This PR builds on #1425 (structured dtype support). Only review the latest commitdd893ce- previous commits are from the base PR.