Skip to content

Fix slow test_patterngen_seeds on Windows by sampling #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andy-Jost merged 2 commits into from
Jan 13, 2026
Merged

Fix slow test_patterngen_seeds on Windows by sampling #1461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d39f754
Fix slow test_patterngen_seeds on Windows by sampling
Andy-Jost Jan 12, 2026
f428279
Merge remote-tracking branch 'origin/main' into fix-slow-patterngen-test
Andy-Jost Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions cuda_core/tests/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ def test_latchkernel():
log("done")


@pytest.mark.skipif(
Copy link
Contributor Author

@Andy-Jost Andy-Jost Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could leave this in if we want to continue skipping this test on Windows. It is not important to test this on every platform IMO.

Copy link
Collaborator

@rwgk rwgk Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% for removing this.

IS_WINDOWS,
reason="Extremely slow on Windows (issue #1455).",
)
@pytest.mark.skipif(
under_compute_sanitizer(),
reason="Too slow under compute-sanitizer (UVM-heavy test).",
Expand All @@ -62,11 +58,13 @@ def test_patterngen_seeds():
buffer = make_scratch_buffer(device, 0, NBYTES)

# All seeds are pairwise different.
# We test a sampling of values because exhaustive testing is too slow,
# especially on Windows. See https://github.com/NVIDIA/cuda-python/issues/1455
pgen = PatternGen(device, NBYTES)
for i in range(256):
for i in (ii for ii in range(0, 256) if ii < 5 or ii % 17 == 0):
pgen.fill_buffer(buffer, seed=i)
pgen.verify_buffer(buffer, seed=i)
for j in range(i + 1, 256):
for j in (jj for jj in range(i + 1, 256) if jj < 5 or jj % 19 == 0):
with pytest.raises(AssertionError):
pgen.verify_buffer(buffer, seed=j)

Expand Down
Loading