-
Notifications
You must be signed in to change notification settings - Fork 274
[no-ci] Use collaborator permission API for restricted-paths-guard trust check #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rwgk
wants to merge
11
commits into
NVIDIA:main
Choose a base branch
from
rwgk:restricted-paths-guard_addl_collaborator_check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−10
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5500d84
Use collaborator permission API instead of event payload author_assoc…
rwgk b814323
TEMPORARY: Switch to pull_request trigger for testing
rwgk 4898bdd
Revert "TEMPORARY: Switch to pull_request trigger for testing"
rwgk 081ff96
Merge branch 'main' into restricted-paths-guard_addl_collaborator_check
rwgk 45b8357
Add explicit handling for non-trusted permission levels
rwgk 8686adb
TEMPORARY: Switch to pull_request trigger for testing
rwgk f5aa8a1
Revert "TEMPORARY: Switch to pull_request trigger for testing"
rwgk a98ddb5
Merge branch 'main' into restricted-paths-guard_addl_collaborator_check
rwgk 500cb29
Fail restricted-paths guard on collaborator API errors
rwgk 2a019b6
TEMPORARY: Switch to pull_request trigger for testing
rwgk 4943745
Revert "TEMPORARY: Switch to pull_request trigger for testing"
rwgk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any handling of the
nonecase you're creating above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's explicit now: commit 45b8357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant: does it need to fail there? Or is
noneacceptable?