Skip to content

ci: guard fromJSON in detect-changes against empty pr-info output #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpcloud merged 1 commit into from
Apr 17, 2026
+9 −1
Merged

ci: guard fromJSON in detect-changes against empty pr-info output #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,15 @@ jobs:
id: filter
if: ${{ startsWith(github.ref_name, 'pull-request/') }}
env:
BASE_REF: ${{ fromJSON(steps.pr-info.outputs.pr-info).base.ref }}
# GitHub Actions evaluates step-level `env:` expressions eagerly —
# the step's `if:` gate does NOT short-circuit them. On non-PR
# events (push/tag/schedule), `pr-info` is skipped and its outputs
# are empty strings, so `fromJSON('')` would raise a template error
# and fail the step despite `if:` being false. Guard the
# `fromJSON` call with a short-circuit so the expression resolves
# to an empty string on non-PR events; the step is still gated
# off by `if:`, so `BASE_REF` is never consumed there.
BASE_REF: ${{ steps.pr-info.outputs.pr-info && fromJSON(steps.pr-info.outputs.pr-info).base.ref || '' }}
run: |
# Diff against the merge base with the PR's actual target branch.
# Uses merge-base so diverged branches only show files changed on
Expand Down
Loading