[no-ci] Check struct and class changes in ABI checking tool#1952
Merged
leofang merged 1 commit intoNVIDIA:mainfrom Apr 22, 2026
Merged
[no-ci] Check struct and class changes in ABI checking tool#1952leofang merged 1 commit intoNVIDIA:mainfrom
leofang merged 1 commit intoNVIDIA:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
4 tasks
Member
|
Q: So this addition allows for checking a C struct's layout & size changes? |
Contributor
Author
Yes. Basically any change to a struct gets reported as an error. |
leofang
approved these changes
Apr 22, 2026
leofang
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to push my agent really hard to use an actual parser and not build up crazy regexes, but I think the result is pretty ok.
This will now detect changes in the size or content of structs and also the sizes of
cdef classes.