Skip to content

[Backport] Remove versioneer #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vzhurba01 merged 7 commits into from
Jan 10, 2025
Merged

[Backport] Remove versioneer #355

vzhurba01 merged 7 commits into from
Jan 10, 2025

Conversation

@leofang
Copy link
Member

@leofang leofang commented Jan 5, 2025 •
edited
Loading

Manually backported to resolve conflicts following #307 (comment). Backporting is needed in order to build wheels from the CI (#233 (comment)).

@leofang leofang requested a review from vzhurba01 January 5, 2025 01:33
@leofang leofang self-assigned this Jan 5, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

leofang
leofang commented Jan 5, 2025
View reviewed changes
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! packaging Anything related to wheels or Conda packages and removed P1 Medium priority - Should do labels Jan 5, 2025
@leofang
Copy link
Member Author

leofang commented Jan 5, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 5, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 8, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 8, 2025

This is ready to review/merge.

@leofang
Copy link
Member Author

leofang commented Jan 10, 2025

/ok to test

@vzhurba01 vzhurba01 mentioned this pull request Jan 10, 2025
Merged
@vzhurba01 vzhurba01 merged commit 1f01b00 into NVIDIA:11.8.x Jan 10, 2025
26 checks passed
@leofang leofang deleted the backport-307-to-11.8.x branch January 10, 2025 18:51
@vzhurba01 vzhurba01 mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vzhurba01 vzhurba01 vzhurba01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leofang leofang

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do! packaging Anything related to wheels or Conda packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang @vzhurba01