Skip to content

Stop tracking cached files and Jupyter notebook hashes in doc builds #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzhurba01 merged 3 commits into from
Jan 31, 2025
Merged

Stop tracking cached files and Jupyter notebook hashes in doc builds #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f99bc3
Remove remaining references to Jupyter notebook
vzhurba01 Jan 30, 2025
532752e
Move cached doctree pickles outside of html build
vzhurba01 Jan 30, 2025
79de389
Merge branch 'main' into 351-trigger
vzhurba01 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cuda_bindings/docs/build_docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if [[ -z "${SPHINX_CUDA_BINDINGS_VER}" ]]; then
fi

# build the docs (in parallel)
SPHINXOPTS="-j 4" make html
SPHINXOPTS="-j 4 -d build/.doctrees" make html

# for debugging/developing (conf.py), please comment out the above line and
# use the line below instead, as we must build in serial to avoid getting
Expand Down
9 changes: 0 additions & 9 deletions cuda_bindings/docs/source/overview.md
View file
Open in desktop
Copy link
Member

@leofang leofang Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: with #424, do we still need this change?

Copy link
Contributor Author

@vzhurba01 vzhurba01 Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do because Jupyter notebook still generates new hashes for the jupytext and kernelspec for every commit

Original file line number Diff line number Diff line change
@@ -1,12 +1,3 @@
---
jupytext:
text_representation:
format_name: myst
kernelspec:
display_name: Python 3
name: python3
---

# Overview

<p style="font-size: 14px; color: grey; text-align: right;">by <a
Expand Down
2 changes: 1 addition & 1 deletion cuda_core/docs/build_docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if [[ -z "${SPHINX_CUDA_CORE_VER}" ]]; then
fi

# build the docs (in parallel)
SPHINXOPTS="-j 4" make html
SPHINXOPTS="-j 4 -d build/.doctrees" make html

# for debugging/developing (conf.py), please comment out the above line and
# use the line below instead, as we must build in serial to avoid getting
Expand Down
2 changes: 1 addition & 1 deletion cuda_python/docs/build_docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if [[ -z "${SPHINX_CUDA_PYTHON_VER}" ]]; then
fi

# build the docs (in parallel)
SPHINXOPTS="-j 4" make html
SPHINXOPTS="-j 4 -d build/.doctrees" make html

# for debugging/developing (conf.py), please comment out the above line and
# use the line below instead, as we must build in serial to avoid getting
Expand Down
Loading