Add `pre-commit-hooks` ("Standard hooks") in `.pre-commit-config.yaml` to get rid of whitespace noise #901

rwgk · 2025-08-25T20:41:16Z

Description

All changes apart from commit ab91593 are automatic whitepspace fixes (from running pre-commit run --all-files).

…ig.yaml

copy-pr-bot · 2025-08-25T20:41:20Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

rwgk · 2025-08-25T20:41:38Z

/ok to test

rwgk · 2025-08-25T20:47:20Z

@leofang What should we do about the generated files listed below?

Exclude from the pre-commit checks?
Tweak the code generator?
We could even just leave everything as-is and simply run pre-commit each time right after we copy over the generated files, but I don't actually like that idea myself.

cuda_bindings/cuda/bindings/_bindings/cydriver.pxd.in
cuda_bindings/cuda/bindings/_bindings/cydriver.pyx.in
cuda_bindings/cuda/bindings/_bindings/cynvrtc.pxd.in
cuda_bindings/cuda/bindings/_lib/cyruntime/utils.pyx.in
cuda_bindings/cuda/bindings/_lib/utils.pxi.in
cuda_bindings/cuda/bindings/cydriver.pxd.in
cuda_bindings/cuda/bindings/cynvrtc.pxd.in
cuda_bindings/cuda/bindings/cyruntime.pxd.in
cuda_bindings/cuda/bindings/cyruntime_functions.pxi.in
cuda_bindings/cuda/bindings/driver.pyx.in
cuda_bindings/cuda/bindings/runtime.pyx.in

leofang

Let's skip all files under cuda_bindings/, or at least the generated ones. Otherwise it's going to be very hard to maintain the code generators.

leofang · 2025-08-25T20:56:51Z

(oh, another instance of us commenting the same time 🙂)

leofang · 2025-08-25T20:57:52Z

btw cuda-bindings' API reference is also autogenerated

This reverts commit f955667.

rwgk · 2025-08-25T21:21:40Z

Let's skip all files under cuda_bindings/, or at least the generated ones. Otherwise it's going to be very hard to maintain the code generators.

Done!

This looks really clean to me now. If we want to exclude more hooks in the future, we can simply add exclude: *gen_exclude lines.

copy-pr-bot · 2025-08-25T21:24:11Z

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

cuda_bindings/docs/source/module/driver.rst

cuda_bindings/docs/source/module/nvrtc.rst

cuda_bindings/docs/source/module/runtime.rst

rwgk · 2025-08-25T21:26:05Z

I think we don't need to rerun the CI:

This worked (only one job still pending):

https://github.com/NVIDIA/cuda-python/actions/runs/17220240290

Net diff between the state for which the CI ran and the latest state of this PR:

$ git diff f955667855c43e6a48192262ac7439d704c8b6c3..fd798ca16503be53d113ebd2e3471816e1d6a9e6 --name-only
.pre-commit-config.yaml
cuda_bindings/cuda/bindings/_bindings/cydriver.pxd.in
cuda_bindings/cuda/bindings/_bindings/cydriver.pyx.in
cuda_bindings/cuda/bindings/_bindings/cynvrtc.pxd.in
cuda_bindings/cuda/bindings/_lib/cyruntime/utils.pyx.in
cuda_bindings/cuda/bindings/_lib/utils.pxi.in
cuda_bindings/cuda/bindings/cydriver.pxd.in
cuda_bindings/cuda/bindings/cynvrtc.pxd.in
cuda_bindings/cuda/bindings/cyruntime.pxd.in
cuda_bindings/cuda/bindings/cyruntime_functions.pxi.in
cuda_bindings/cuda/bindings/driver.pyx.in
cuda_bindings/cuda/bindings/runtime.pyx.in

.pre-commit-config.yaml

leofang

Thanks a lot, Ralf! LGTM!

github-actions · 2025-08-25T22:03:02Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

* Initial plan * Create Sphinx documentation infrastructure for cuda.pathfinder Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Fix title underline and test pathfinder documentation build Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Address all review feedback - fix references, remove unnecessary files, populate API docs Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Add cuda-pathfinder documentation link to CI doc preview Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * [pre-commit.ci] auto code formatting * Update cuda-core and cuda-bindings README to reference nv-versions.json Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Refactor pathfinder documentation based on review feedback - Remove lines 7-14 from api.rst (cuda.pathfinder automodule section) - Convert api.rst to use autosummary instead of direct autodoc directives following cuda-core pattern - Convert contribute.md to contribute.rst in ReST format - Remove _templates/main.html file as it's no longer needed - Update index.rst to reference contribute.rst instead of contribute.md Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Add release notes for cuda-pathfinder versions 1.0.0 and 1.1.0 - Created release directory structure under cuda_pathfinder/docs/source/release/ - Added 1.0.0-notes.rst with initial release highlights - Added 1.1.0-notes.rst with CTK 13.0.0 compatibility and bug fixes - Added release.rst index file to organize release notes - Updated index.rst to include release notes in navigation - Follows established documentation patterns from cuda-core and cuda-bindings Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Fix SPDX license identifiers and add 1.1.1 release notes for PRs #834 and #855 Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Restore _templates/main.html file as requested in review feedback Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> * Change format as requested by Leo #884 (comment) * Remove stray cuda/pathfinder/README.md URL in cuda_python/docs/source/index.rst * Rename release 1.1.1 to 1.X.Y * Add version 1.0.0 in cuda_pathfinder/docs/nv-versions.json * Remove unused cuda_pathfinder/docs/make.bat * Revert "Add version 1.0.0 in cuda_pathfinder/docs/nv-versions.json" This reverts commit d096d21. * Reduce divergence between cuda_bindings/docs/source/contribute.rst and cuda_pathfinder/docs/source/contribute.rst * New pre-commit fixes (related to PR #901) * Also remove version 1.1.0 from cuda_pathfinder/docs/nv-versions.json * Reduce cuda/pathfinder/README.md to a mere pointer to the sphinx-generated documentation. * Add the Search order section from the old README as a new section in the load_nvidia_dynamic_lib() docstring. * Leo's edits to new part of load_nvidia_dynamic_lib docstring Co-authored-by: Leo Fang <leof@nvidia.com> * Add more empty lines in load_nvidia_dynamic_lib docstring * Remove `**` around Linux, Windows (for consistency) * Fix existing (on main) pre-commit error * Add `*/docs/source/generated/` to .gitignore * Add toolshed/setup-docs-env.sh --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: leofang <5534781+leofang@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Leo Fang <leof@nvidia.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com>

rwgk added 2 commits August 25, 2025 13:34

Copy pre-commit-hooks "Standard hooks" from pybind11/.pre-commit-conf…

ab91593

…ig.yaml

Automatic whitespace fixes — NO manual changes.

f955667

leofang requested changes Aug 25, 2025

View reviewed changes

leofang requested a review from mdboom August 25, 2025 20:47

leofang assigned rwgk Aug 25, 2025

leofang added enhancement Any code-related improvements P1 Medium priority - Should do CI/CD CI/CD infrastructure labels Aug 25, 2025

leofang added this to the cuda.core beta 7 milestone Aug 25, 2025

This comment has been minimized.

Sign in to view

rwgk added 3 commits August 25, 2025 14:07

Revert "Automatic whitespace fixes — NO manual changes."

e582ec8

This reverts commit f955667.

gen_exclude at top level

06589dc

Automatic whitespace fixes — NO manual changes.

fd798ca

rwgk marked this pull request as ready for review August 25, 2025 21:24

leofang reviewed Aug 25, 2025

View reviewed changes

cuda_bindings/docs/source/module/driver.rst Show resolved Hide resolved

cuda_bindings/docs/source/module/nvrtc.rst Show resolved Hide resolved

cuda_bindings/docs/source/module/runtime.rst Show resolved Hide resolved

leofang reviewed Aug 25, 2025

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

rwgk and others added 3 commits August 25, 2025 14:31

git checkout main cuda_bindings/docs/source/module/*.rst

8001d51

Add $|cuda_bindings/docs/source/module/.*\.rst?$ to gen_exclude

4479294

Merge branch 'main' into pre-commit-standard-hooks

27fa959

leofang approved these changes Aug 25, 2025

View reviewed changes

leofang merged commit 811cb93 into NVIDIA:main Aug 25, 2025
1 check passed

rwgk added a commit that referenced this pull request Aug 25, 2025

New pre-commit fixes (related to PR #901)

aebd77e

Add pre-commit-hooks ("Standard hooks") in .pre-commit-config.yaml to get rid of whitespace noise #901

Add pre-commit-hooks ("Standard hooks") in .pre-commit-config.yaml to get rid of whitespace noise #901

Uh oh!

Conversation

rwgk commented Aug 25, 2025

Description

Uh oh!

copy-pr-bot bot commented Aug 25, 2025

Uh oh!

rwgk commented Aug 25, 2025

Uh oh!

rwgk commented Aug 25, 2025

Uh oh!

leofang left a comment

Choose a reason for hiding this comment

Uh oh!

leofang commented Aug 25, 2025

Uh oh!

This comment has been minimized.

leofang commented Aug 25, 2025

Uh oh!

rwgk commented Aug 25, 2025

Uh oh!

copy-pr-bot bot commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rwgk commented Aug 25, 2025

Uh oh!

Uh oh!

leofang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add `pre-commit-hooks` ("Standard hooks") in `.pre-commit-config.yaml` to get rid of whitespace noise #901

Add `pre-commit-hooks` ("Standard hooks") in `.pre-commit-config.yaml` to get rid of whitespace noise #901