Skip to content

Pre commit fixes #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leofang merged 3 commits into from
Aug 27, 2025
Merged

Pre commit fixes #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d12b9e0
Define gen_exclude anchor at first use to resolve warning
rwgk Aug 27, 2025
240d637
Remove requirements-txt-fixer
rwgk Aug 27, 2025
ed25cc7
Change the commit hash in .github/workflows/bandit.yml
rwgk Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bandit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ jobs:
security-events: write
steps:
- name: Perform Bandit Analysis
uses: PyCQA/bandit-action@67a458d90fa11fb1463e91e7f4c8f068b5863c7f # v1.0.1
uses: PyCQA/bandit-action@8a1b30610f61f3f792fe7556e888c9d7dffa52de
Copy link
Collaborator

@kkraus14 kkraus14 Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this associated with a specific tag?

Copy link
Member

@leofang leofang Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came from a copy/paste from the global allowlist. At this point I am not sure it makes sense for us to dig out the corresponding version if we don't own the version bump?

Copy link
Collaborator

@kkraus14 kkraus14 Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit tied to v1.0.0 where this would be a downgrade that also includes running on Python 3.8 which is EOL.

Copy link
Collaborator Author

@rwgk rwgk Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the workflow runs with this, which seems like a strict improvement for the minute.

I want to propose to work on it more in a follow-on PR. In the meantime I figured out a simple approach to keep the workflow and pre-commit in sync (manually).

But should I add the # v1.0.0 comment here? (I missed that before.)

(Then you could admin merge.)

Copy link
Collaborator

@kkraus14 kkraus14 Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess let's add the comment for v1.0.0 here for now and then upgrade it once things are fixed at the org level

5 changes: 1 addition & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ ci:
skip: [bandit]
submodules: false

gen_exclude: &gen_exclude '^cuda_bindings/cuda/bindings/.*\.in?$|cuda_bindings/docs/source/module/.*\.rst?$'

# Please update the rev: SHAs below with this command:
# pre-commit autoupdate --freeze
repos:
Expand Down Expand Up @@ -54,9 +52,8 @@ repos:
- id: check-yaml
- id: debug-statements
- id: end-of-file-fixer
exclude: *gen_exclude
exclude: &gen_exclude '^(?:cuda_bindings/cuda/bindings/.*\.in?|cuda_bindings/docs/source/module/.*\.rst?)$'
- id: mixed-line-ending
- id: requirements-txt-fixer
- id: trailing-whitespace
exclude: *gen_exclude

Expand Down
Loading