Skip to content

Fix #702: Update cyruntime.getLocalRuntimeVersion to use pathfinder #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leofang merged 18 commits into from
Sep 16, 2025
Merged

Fix #702: Update cyruntime.getLocalRuntimeVersion to use pathfinder #929

leofang merged 18 commits into from
Sep 16, 2025

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Aug 29, 2025 •
edited
Loading

Description

closes #702

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Aug 29, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom
Copy link
Contributor Author

mdboom commented Aug 29, 2025

/ok to test

3 similar comments
@mdboom
Copy link
Contributor Author

mdboom commented Aug 29, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Aug 29, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Aug 29, 2025

/ok to test

@github-actions
Copy link

github-actions bot commented Aug 29, 2025

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-929/

https://nvidia.github.io/cuda-python/pr-preview/pr-929/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-929/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-929/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@mdboom
Copy link
Contributor Author

mdboom commented Aug 29, 2025

I'm not sure what's happening here, but maybe @rwgk knows? The load_nvidia_dynamic_lib("cudart") call is failing to find the library, but only on certain combinations of Python and CUDA versions...

leofang
leofang reviewed Aug 29, 2025
View reviewed changes
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module labels Aug 30, 2025
@leofang leofang added this to the cuda-python 13-next, 12-next milestone Aug 30, 2025
@mdboom
Copy link
Contributor Author

mdboom commented Sep 2, 2025

/ok to test

kkraus14
kkraus14 reviewed Sep 2, 2025
View reviewed changes
@mdboom
Copy link
Contributor Author

mdboom commented Sep 2, 2025

The CI failures seem to be when "LOCAL_CTK=0" and "CUDA_VER=13.0.0". Is there a reason cudart.so might not be present when LOCAL_CTK=0?

@mdboom
Copy link
Contributor Author

mdboom commented Sep 2, 2025

/ok to test

@mdboom mdboom marked this pull request as ready for review September 2, 2025 16:06
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 2, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom
Copy link
Contributor Author

mdboom commented Sep 2, 2025

/ok to test

@mdboom mdboom requested review from kkraus14 and leofang September 2, 2025 16:52
@leofang
Copy link
Member

leofang commented Sep 2, 2025

The CI failures seem to be when "LOCAL_CTK=0" and "CUDA_VER=13.0.0". Is there a reason cudart.so might not be present when LOCAL_CTK=0?

Yes. Because we do not require the cudart wheel to be installed. libcudart.so.N exists in the nvidia-cuda-runtime[-cuXX] wheels. In such cases, the test should be waived. @rwgk might know how to write a good skip condition here...

rwgk
rwgk previously approved these changes Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! My only concern is reporting only the basename in the error message.

rwgk
rwgk reviewed Sep 2, 2025
View reviewed changes
@mdboom mdboom marked this pull request as draft September 4, 2025 13:21
@mdboom
Copy link
Contributor Author

mdboom commented Sep 4, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Sep 4, 2025

Converting to draft -- this will need to be rebased to not use pywin32 after #942 is merged.

@mdboom
Copy link
Contributor Author

mdboom commented Sep 4, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Sep 15, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Sep 15, 2025

/ok to test

@mdboom mdboom marked this pull request as ready for review September 15, 2025 18:21
@mdboom mdboom requested a review from rwgk September 15, 2025 18:21
rwgk
rwgk previously approved these changes Sep 15, 2025
View reviewed changes
leofang
leofang reviewed Sep 16, 2025
View reviewed changes
@leofang
Copy link
Member

leofang commented Sep 16, 2025

LGTM too!

@mdboom
Copy link
Contributor Author

mdboom commented Sep 16, 2025

/ok to test

leofang
leofang requested changes Sep 16, 2025
View reviewed changes
@mdboom
Copy link
Contributor Author

mdboom commented Sep 16, 2025

/ok to test

@leofang
Copy link
Member

leofang commented Sep 16, 2025

LGTM! Let's add a release note (to both 13.X.Y and 12.9.X, since this will be backported).

rwgk
rwgk previously approved these changes Sep 16, 2025
View reviewed changes
@mdboom
Copy link
Contributor Author

mdboom commented Sep 16, 2025

/ok to test

@mdboom mdboom requested a review from leofang September 16, 2025 20:02
@leofang leofang merged commit 3749929 into NVIDIA:main Sep 16, 2025
49 checks passed
@mdboom mdboom deleted the issue702 branch December 9, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

@leofang leofang leofang approved these changes

@kkraus14 kkraus14 Awaiting requested review from kkraus14

Assignees

@mdboom mdboom

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Milestone

cuda-python 13.0.2 & 12.9.3

Development

Successfully merging this pull request may close these issues.

[FEA]: runtime.getLocalRuntimeVersion() → path_finder

4 participants

@mdboom @leofang @rwgk @kkraus14