Skip to content

Fail if no "INFO test_" lines are found in pathfinder test output #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rwgk merged 2 commits into from
Sep 19, 2025
Merged

Fail if no "INFO test_" lines are found in pathfinder test output #979

rwgk merged 2 commits into from
Sep 19, 2025

Conversation

@rwgk
Copy link
Collaborator

@rwgk rwgk commented Sep 17, 2025

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 17, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk rwgk self-assigned this Sep 17, 2025
@rwgk rwgk added the cuda.pathfinder Everything related to the cuda.pathfinder module label Sep 17, 2025
@rwgk rwgk mentioned this pull request Sep 17, 2025
Merged
@rwgk
Copy link
Collaborator Author

rwgk commented Sep 17, 2025

/ok to test

@cpcloud
Copy link
Contributor

cpcloud commented Sep 17, 2025

Seems like this bakes in a formatting choice to CI passing or failing. Are these INFO lines used in something downstream?

@github-actions

This comment has been minimized.

Sign in to view
@rwgk
Copy link
Collaborator Author

rwgk commented Sep 17, 2025

/ok to test

@rwgk
Copy link
Collaborator Author

rwgk commented Sep 18, 2025

Manual QA:

gh api "/repos/NVIDIA/cuda-python/actions/runs/17811726673/logs" > logs_17811726673.zip
unzip logs_17811726673.zip
grep 'Number of "INFO test_" lines:' *Test*.txt

10_Test linux-aarch64 _ py3.9, 12.9.1, wheels, GPU a100.txt:2025-09-17T22:19:28.2119914Z Number of "INFO test_" lines: 43
10_Test linux-aarch64 _ py3.9, 12.9.1, wheels, GPU a100.txt:2025-09-17T22:20:51.8602596Z Number of "INFO test_" lines: 49
11_Test linux-aarch64 _ py3.10, 13.0.1, wheels, GPU a100.txt:2025-09-17T22:18:51.3652398Z Number of "INFO test_" lines: 43
11_Test linux-aarch64 _ py3.10, 13.0.1, wheels, GPU a100.txt:2025-09-17T22:20:21.5058291Z Number of "INFO test_" lines: 46
12_Test linux-aarch64 _ py3.11, 13.0.1, local, GPU a100.txt:2025-09-17T22:19:02.9706718Z Number of "INFO test_" lines: 43
12_Test linux-aarch64 _ py3.11, 13.0.1, local, GPU a100.txt:2025-09-17T22:21:12.2171101Z Number of "INFO test_" lines: 46
13_Test linux-aarch64 _ py3.9, 13.0.1, local, GPU a100.txt:2025-09-17T22:18:58.9971165Z Number of "INFO test_" lines: 43
13_Test linux-aarch64 _ py3.9, 13.0.1, local, GPU a100.txt:2025-09-17T22:20:33.8428011Z Number of "INFO test_" lines: 46
14_Test linux-aarch64 _ py3.13, 13.0.1, local, GPU a100.txt:2025-09-17T22:18:13.1582225Z Number of "INFO test_" lines: 43
14_Test linux-aarch64 _ py3.13, 13.0.1, local, GPU a100.txt:2025-09-17T22:20:20.4097421Z Number of "INFO test_" lines: 46
15_Test linux-64 _ py3.9, 12.9.1, wheels, GPU l4.txt:2025-09-17T23:07:17.0409181Z Number of "INFO test_" lines: 43
15_Test linux-64 _ py3.9, 12.9.1, wheels, GPU l4.txt:2025-09-17T23:08:59.4226557Z Number of "INFO test_" lines: 48
16_Test linux-64 _ py3.10, 13.0.1, wheels, GPU l4.txt:2025-09-17T23:06:55.5111773Z Number of "INFO test_" lines: 43
16_Test linux-64 _ py3.10, 13.0.1, wheels, GPU l4.txt:2025-09-17T23:08:20.8835686Z Number of "INFO test_" lines: 45
17_Test linux-64 _ py3.13, 13.0.1, local, GPU l4.txt:2025-09-17T23:05:44.6297234Z Number of "INFO test_" lines: 43
17_Test linux-64 _ py3.13, 13.0.1, local, GPU l4.txt:2025-09-17T23:07:45.7613373Z Number of "INFO test_" lines: 45
18_Test linux-64 _ py3.12, 13.0.1, wheels, GPU l4.txt:2025-09-17T23:07:06.9436712Z Number of "INFO test_" lines: 43
18_Test linux-64 _ py3.12, 13.0.1, wheels, GPU l4.txt:2025-09-17T23:08:33.4020901Z Number of "INFO test_" lines: 45
19_Test linux-64 _ py3.13, 13.0.1, local, GPU H100.txt:2025-09-17T23:50:23.9119700Z Number of "INFO test_" lines: 43
19_Test linux-64 _ py3.13, 13.0.1, local, GPU H100.txt:2025-09-17T23:52:39.6367450Z Number of "INFO test_" lines: 45
1_Test win-64 _ py3.13, 13.0.1, local, GPU l4.txt:2025-09-17T22:36:59.7569901Z Number of "INFO test_" lines: 41
1_Test win-64 _ py3.13, 13.0.1, local, GPU l4.txt:2025-09-17T22:39:06.3029433Z Number of "INFO test_" lines: 41
20_Test linux-64 _ py3.13, 12.9.1, wheels, GPU l4.txt:2025-09-17T23:00:09.1412520Z Number of "INFO test_" lines: 43
20_Test linux-64 _ py3.13, 12.9.1, wheels, GPU l4.txt:2025-09-17T23:01:49.9181908Z Number of "INFO test_" lines: 48
21_Test linux-64 _ py3.11, 13.0.1, local, GPU l4.txt:2025-09-17T23:00:40.1393459Z Number of "INFO test_" lines: 43
21_Test linux-64 _ py3.11, 13.0.1, local, GPU l4.txt:2025-09-17T23:02:38.9177341Z Number of "INFO test_" lines: 45
22_Test linux-64 _ py3.11, 12.9.1, wheels, GPU l4.txt:2025-09-17T23:01:14.0660132Z Number of "INFO test_" lines: 43
22_Test linux-64 _ py3.11, 12.9.1, wheels, GPU l4.txt:2025-09-17T23:02:57.9739211Z Number of "INFO test_" lines: 48
23_Test linux-64 _ py3.9, 13.0.1, local, GPU l4.txt:2025-09-17T22:47:14.3413812Z Number of "INFO test_" lines: 43
23_Test linux-64 _ py3.9, 13.0.1, local, GPU l4.txt:2025-09-17T22:48:38.0112066Z Number of "INFO test_" lines: 45
24_Test linux-64 _ py3.10, 12.9.1, local, GPU l4.txt:2025-09-17T22:58:02.3511318Z Number of "INFO test_" lines: 43
24_Test linux-64 _ py3.10, 12.9.1, local, GPU l4.txt:2025-09-17T22:59:58.7363749Z Number of "INFO test_" lines: 48
25_Test linux-64 _ py3.12, 12.9.1, local, GPU l4.txt:2025-09-17T22:47:25.2101519Z Number of "INFO test_" lines: 43
25_Test linux-64 _ py3.12, 12.9.1, local, GPU l4.txt:2025-09-17T22:49:37.6478294Z Number of "INFO test_" lines: 48
2_Test win-64 _ py3.13, 13.0.1, wheels, GPU t4.txt:2025-09-17T22:23:36.2679905Z Number of "INFO test_" lines: 41
2_Test win-64 _ py3.13, 13.0.1, wheels, GPU t4.txt:2025-09-17T22:27:05.3019306Z Number of "INFO test_" lines: 41
3_Test win-64 _ py3.12, 12.9.1, wheels, GPU l4.txt:2025-09-17T23:09:48.9397437Z Number of "INFO test_" lines: 41
3_Test win-64 _ py3.12, 12.9.1, wheels, GPU l4.txt:2025-09-17T23:11:43.8944297Z Number of "INFO test_" lines: 42
4_Test win-64 _ py3.12, 12.9.1, local, GPU t4.txt:2025-09-17T22:26:20.9498126Z Number of "INFO test_" lines: 41
4_Test win-64 _ py3.12, 12.9.1, local, GPU t4.txt:2025-09-17T22:31:10.4723541Z Number of "INFO test_" lines: 42
5_Test linux-aarch64 _ py3.11, 12.9.1, wheels, GPU a100.txt:2025-09-17T22:29:08.2589306Z Number of "INFO test_" lines: 43
5_Test linux-aarch64 _ py3.11, 12.9.1, wheels, GPU a100.txt:2025-09-17T22:30:33.0902635Z Number of "INFO test_" lines: 49
6_Test linux-aarch64 _ py3.10, 12.9.1, local, GPU a100.txt:2025-09-17T22:24:52.6218239Z Number of "INFO test_" lines: 43
6_Test linux-aarch64 _ py3.10, 12.9.1, local, GPU a100.txt:2025-09-17T22:26:59.6113007Z Number of "INFO test_" lines: 49
7_Test linux-aarch64 _ py3.12, 12.9.1, local, GPU a100.txt:2025-09-17T22:23:25.1678476Z Number of "INFO test_" lines: 43
7_Test linux-aarch64 _ py3.12, 12.9.1, local, GPU a100.txt:2025-09-17T22:25:37.9983076Z Number of "INFO test_" lines: 49
8_Test linux-aarch64 _ py3.13, 12.9.1, wheels, GPU a100.txt:2025-09-17T22:22:38.7643166Z Number of "INFO test_" lines: 43
8_Test linux-aarch64 _ py3.13, 12.9.1, wheels, GPU a100.txt:2025-09-17T22:24:11.2889598Z Number of "INFO test_" lines: 49
9_Test linux-aarch64 _ py3.12, 13.0.1, wheels, GPU a100.txt:2025-09-17T22:19:02.8477538Z Number of "INFO test_" lines: 43
9_Test linux-aarch64 _ py3.12, 13.0.1, wheels, GPU a100.txt:2025-09-17T22:20:31.6876995Z Number of "INFO test_" lines: 46

@rwgk
Copy link
Collaborator Author

rwgk commented Sep 18, 2025

Seems like this bakes in a formatting choice to CI passing or failing. Are these INFO lines used in something downstream?

Only visually while developing, and for things like manual QA here:

#956 (comment)

It's a very basic formatting choice, unlikely to change. In the worst case we'd have to adjust a couple lines, all in one place.

@rwgk rwgk marked this pull request as ready for review September 18, 2025 00:21
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Sep 18, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang leofang requested a review from cpcloud September 19, 2025 18:53
@cpcloud
Copy link
Contributor

cpcloud commented Sep 19, 2025

Seems fine.

@rwgk
Copy link
Collaborator Author

rwgk commented Sep 19, 2025

Thanks @cpcloud!

@rwgk rwgk merged commit 5876145 into NVIDIA:main Sep 19, 2025
49 checks passed
@rwgk rwgk deleted the ci_pathfinder_info_check branch September 19, 2025 22:43
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees

@rwgk rwgk

Labels

cuda.pathfinder Everything related to the cuda.pathfinder module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk @cpcloud