Stabilizing the build and enabling tests#1001
Merged
khalatepradnya merged 3 commits intoNVIDIA:experimental/pythonfrom Dec 29, 2023
Merged
Stabilizing the build and enabling tests#1001khalatepradnya merged 3 commits intoNVIDIA:experimental/pythonfrom
khalatepradnya merged 3 commits intoNVIDIA:experimental/pythonfrom
Conversation
amccaskey
reviewed
Dec 8, 2023
khalatepradnya
commented
Dec 12, 2023
amccaskey
reviewed
Dec 14, 2023
Collaborator
Author
|
To be merged after #1058 |
* Adjusted calls for assertion * Addressing the following warning - "DeprecationWarning: expectation_z() is deprecated, use expectation() with the same argument structure." * Renamed tests under 'eager' directory so top-level 'tests' can be run with 'pytest'
'python_runtime' * Spelling check updates
Collaborator
Author
Command Bot: Processing... |
bmhowe23
reviewed
Dec 29, 2023
Collaborator
Author
Command Bot: Processing... |
amccaskey
approved these changes
Dec 29, 2023
Collaborator
amccaskey
left a comment
amccaskey
left a comment
There was a problem hiding this comment.
Thanks for the pybind version fix. Most everything here looks like code formatting. LGTM +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initialize_statefunctionality