-
Notifications
You must be signed in to change notification settings - Fork 161
Cleanup early heuristics logs + unify cutoff/upper_bound in B&B #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
a0ce987
initial commit
aliceb-nv 5e06221
Merge branch 'release/26.04' into no-cutoff-bb
aliceb-nv cfa1758
remove separate cutoff value
aliceb-nv cc7e99f
ai review comments
aliceb-nv 62b1ba5
ai review comments
aliceb-nv 15aa2d8
fix duplicate log line
aliceb-nv 32cca62
address chris' comments (thanks!)
aliceb-nv 35dc789
fix grpc test using very large coefficients instead of infinity
aliceb-nv a1ef25e
Merge branch 'release/26.04' into no-cutoff-bb
aliceb-nv 980cd24
stop rins before the population flush to avoid missing on new solutions
aliceb-nv fcc3cd2
bump1
aliceb-nv d2fba96
bump2
aliceb-nv 4fc9953
bump3
aliceb-nv 751b8c4
fix compilation
aliceb-nv c3f6b6f
bump1
aliceb-nv a4954b5
bump2
aliceb-nv fee8edb
bump3
aliceb-nv 02b794a
Merge branch 'release/26.04' into no-cutoff-bb
aliceb-nv 2202b88
missing dataset
aliceb-nv c3e9c2b
cleanup
aliceb-nv 6472058
ai review comments
aliceb-nv e039851
AI review comment
aliceb-nv 4109e00
oversight
aliceb-nv 6357f8a
Merge branch 'release/26.04' into no-cutoff-bb
aliceb-nv 14b86e4
Empty commit
rgsl888prabhu 0e5d755
fix grpc versions
rgsl888prabhu 3c9b1d1
update ignore run exports for mps
rgsl888prabhu 19f54b9
fix rbb overlinking failuret
rgsl888prabhu 5f12bf3
fix tbb
rgsl888prabhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What specifically were the conflicts? Would it be sufficient to just make this a floor and not include a ceiling?
A tight pin like this is going to cause environment conflicts, especially in the all-of-RAPIDS conda environment in the devcontainers: https://github.com/rapidsai/devcontainers/blob/51ebbe3e6ae8120b9aba229729ef322bc18bbd4a/.github/workflows/test.yml#L29
I'd love the opportunity to help you find a less-restrictive fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue was libcuopt built with latest libgrpc 1.8x, but pyarrow used libgrpc 1.7x, so while testing they diverged and started breaking due to dependency issue. https://github.com/NVIDIA/cuopt/actions/runs/24077889439/job/70243128275?pr=1033
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oy 😫
Repeating what I wrote privately so we have it here in GitHub, I guess it's this part?
cuoptpicks up a very-newlibgrpc(looks like 1.80.0 was released earlier today), and that's fine at build time but causes issues at runtime becausecudfneedspyarrowandpyarrow's dependencies eventually needlibgrpcand only support older versions.blegh let me think a bit about how we could work around this. Please feel free to merge this PR for now if it's blocking other work, we can fix the pin in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jameslamb