Exclude L1TESTs from contributing instructions#1034
Merged
rapids-bot[bot] merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
📝 WalkthroughWalkthroughThe CONTRIBUTING.md file has been updated to modify the C++ test execution command by adding an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CONTRIBUTING.md`:
- Line 202: Update the rationale sentence in CONTRIBUTING.md that references
`L1TEST`s: replace the word "expensive" with a clear statement that L1TESTs are
excluded because they are currently broken and not run in CI (or similar wording
like "currently broken/not included in CI"), so the rationale matches the PR
reason; ensure the line containing the backticked token `L1TEST`s is changed to
the new wording and keep the tone consistent with surrounding contribution
guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9113efcf-8281-4a3b-a494-e76e51d7c7f9
📒 Files selected for processing (1)
CONTRIBUTING.md
hlinsen
approved these changes
Apr 3, 2026
rgsl888prabhu
approved these changes
Apr 3, 2026
Collaborator
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are expensive, currently broken, and aren't covered under CI. New contributors will be confused if they see failing tests, so they should be excluded from the instructions.