Skip to content

Exclude L1TESTs from contributing instructions#1034

Merged
rapids-bot[bot] merged 1 commit intomainfrom
mlubin-patch-1
Apr 3, 2026
Merged

Exclude L1TESTs from contributing instructions#1034
rapids-bot[bot] merged 1 commit intomainfrom
mlubin-patch-1

Conversation

@mlubin
Copy link
Copy Markdown
Contributor

@mlubin mlubin commented Apr 3, 2026

These tests are expensive, currently broken, and aren't covered under CI. New contributors will be confused if they see failing tests, so they should be excluded from the instructions.

@mlubin mlubin requested a review from hlinsen April 3, 2026 16:25
@mlubin mlubin requested a review from a team as a code owner April 3, 2026 16:25
@mlubin mlubin added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Apr 3, 2026
@mlubin mlubin requested a review from Iroy30 April 3, 2026 16:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

📝 Walkthrough

Walkthrough

The CONTRIBUTING.md file has been updated to modify the C++ test execution command by adding an -E L1TEST filter to exclude L1TEST tests from the default developer test run, with accompanying documentation explaining the rationale.

Changes

Cohort / File(s) Summary
Documentation Update
CONTRIBUTING.md
Modified ctest invocation to include -E L1TEST filter, excluding L1TEST tests from default developer testing. Added explanatory text noting that L1TEST tests are excluded due to expense and are not part of typical development workflows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: excluding L1TESTs from contributing instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the rationale for excluding L1TESTs from contributing instructions due to cost, breakage, and lack of CI coverage.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mlubin-patch-1

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CONTRIBUTING.md`:
- Line 202: Update the rationale sentence in CONTRIBUTING.md that references
`L1TEST`s: replace the word "expensive" with a clear statement that L1TESTs are
excluded because they are currently broken and not run in CI (or similar wording
like "currently broken/not included in CI"), so the rationale matches the PR
reason; ensure the line containing the backticked token `L1TEST`s is changed to
the new wording and keep the tone consistent with surrounding contribution
guidance.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9113efcf-8281-4a3b-a494-e76e51d7c7f9

📥 Commits

Reviewing files that changed from the base of the PR and between 26f2c93 and 857a86b.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

Comment thread CONTRIBUTING.md
@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 40c8f04 into main Apr 3, 2026
76 checks passed
@mlubin mlubin deleted the mlubin-patch-1 branch April 3, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants