Fix issue when problem has an empty problem in pdlp#107
Merged
rapids-bot[bot] merged 2 commits intobranch-25.08from Jun 17, 2025
Merged
Fix issue when problem has an empty problem in pdlp#107rapids-bot[bot] merged 2 commits intobranch-25.08from
rapids-bot[bot] merged 2 commits intobranch-25.08from
Conversation
Kh4ster
requested review from
aliceb-nv and
rg20
and removed request for
aliceb-nv
Kh4ster
added
bug
rg20
approved these changes
Jun 17, 2025
Contributor
|
/merge |
Contributor
|
@Kh4ster This was already merged. But what about instead of just saying we can't handle a problem with no constraints in PDLP, why don't we just add an empty constraint (e.g 0 * x == 0, or -inf <= 0 * x <= inf ) |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
Fixes NVIDIA#103 - Matrix with an empty problem no longer triggers an assert. - If in PDLP mode, a LOG_INFO tells the user he should use DualSimplex instead and returns a NumericalError - If in Concurrent mode, PDLP will stop but Dual Simplex will solve the problem Authors: - Nicolas Blin (https://github.com/Kh4ster) Approvers: - Rajesh Gandham (https://github.com/rg20) URL: NVIDIA#107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103