Skip to content

Fix double va_start undefined behavior in error handling #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Apr 15, 2026
+1 −7
Merged

Fix double va_start undefined behavior in error handling #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6f223d
Fix double va_start undefined behavior in error handling functions
rgsl888prabhu Apr 9, 2026
7000b02
Merge branch 'main' into fix/double-va-start-undefined-behavior
rgsl888prabhu Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cpp/include/cuopt/error.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ inline void cuopt_expects(bool cond, error_type_t error_type, const char* fmt, .
if (not cond) {
va_list args;
va_start(args, fmt);

char msg[2048];
va_start(args, fmt);
vsnprintf(msg, sizeof(msg), fmt, args);
va_end(args);

Expand Down
6 changes: 1 addition & 5 deletions cpp/libmps_parser/src/utilities/error.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* clang-format off */
/*
* SPDX-FileCopyrightText: Copyright (c) 2023-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/
/* clang-format on */
Expand Down Expand Up @@ -49,9 +49,7 @@ inline void mps_parser_expects(bool cond, error_type_t error_type, const char* f
if (not cond) {
va_list args;
va_start(args, fmt);

char msg[2048];
va_start(args, fmt);
vsnprintf(msg, sizeof(msg), fmt, args);
va_end(args);

Expand All @@ -75,9 +73,7 @@ inline void mps_parser_expects_fatal(bool cond, error_type_t error_type, const c
if (not cond) {
va_list args;
va_start(args, fmt);

char msg[2048];
va_start(args, fmt);
vsnprintf(msg, sizeof(msg), fmt, args);
va_end(args);
std::string error_string = error_to_string(error_type);
Expand Down
Loading