Skip to content

Bump libcuopt wheel size#1087

Merged
rgsl888prabhu merged 1 commit intoNVIDIA:mainfrom
rgsl888prabhu:bump_libcuopt_wheel_size
Apr 9, 2026
Merged

Bump libcuopt wheel size#1087
rgsl888prabhu merged 1 commit intoNVIDIA:mainfrom
rgsl888prabhu:bump_libcuopt_wheel_size

Conversation

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

Description

libcuopt wheel-build is failing because of the size.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner April 9, 2026 16:18
@rgsl888prabhu rgsl888prabhu requested a review from AyodeAwe April 9, 2026 16:18
@rgsl888prabhu rgsl888prabhu self-assigned this Apr 9, 2026
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Apr 9, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

📝 Walkthrough

Walkthrough

Updated pydistcheck size thresholds in CI validation script for python/libcuopt wheels. Increased --max-allowed-size-compressed limits from 650Mi to 665Mi for CUDA 12, and from 495Mi to 505Mi for other CUDA versions.

Changes

Cohort / File(s) Summary
CI validation configuration
ci/validate_wheel.sh
Raised pydistcheck --max-allowed-size-compressed thresholds for python/libcuopt wheel validation across different CUDA major versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Bump libcuopt size by 5 mb  #1016: Also modifies ci/validate_wheel.sh to adjust pydistcheck --max-allowed-size-compressed thresholds for the same python/libcuopt validation.

Suggested labels

non-breaking, improvement

Suggested reviewers

  • KyleFromNVIDIA
  • jameslamb
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Bump libcuopt wheel size' directly summarizes the main change: increasing size thresholds for libcuopt wheels.
Description check ✅ Passed The description explains the purpose of the change (fixing wheel-build failure due to size) which is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ci/validate_wheel.sh (1)

22-31: Consider documenting the root cause of the size increase for future maintainability.

The size limit increases are reasonable and well within PyPI's 1GiB hard limit. The modest increases (15Mi for CUDA 12, 10Mi for others) make sense given the heavy dependencies (cuda-toolkit, nvidia-cudss-cu13, nvidia-nvjitlink, etc.) included in the wheel.

However, the commit message "bump size" doesn't explain what triggered this adjustment. For future maintenance, it would be helpful to add context about whether this was due to:

  • A dependency version update
  • New features or functionality added
  • A required configuration change

This information would help prevent similar build failures and clarify why these specific thresholds were chosen.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ci/validate_wheel.sh` around lines 22 - 31, Add a short explanatory comment
above the conditional that adjusts PYDISTCHECK_ARGS (the block checking
package_dir == "python/libcuopt" and RAPIDS_CUDA_MAJOR) describing why the size
limits were bumped: state the root cause (e.g., dependency version updates or
specific added binaries like cuda-toolkit, nvidia-cudss-cu13, nvidia-nvjitlink)
and which change triggered the increase, include the exact delta values (15Mi
for CUDA 12, 10Mi for others) and reference the related commit/issue ID or PR
for future reference so maintainers understand why these thresholds were chosen.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@ci/validate_wheel.sh`:
- Around line 22-31: Add a short explanatory comment above the conditional that
adjusts PYDISTCHECK_ARGS (the block checking package_dir == "python/libcuopt"
and RAPIDS_CUDA_MAJOR) describing why the size limits were bumped: state the
root cause (e.g., dependency version updates or specific added binaries like
cuda-toolkit, nvidia-cudss-cu13, nvidia-nvjitlink) and which change triggered
the increase, include the exact delta values (15Mi for CUDA 12, 10Mi for others)
and reference the related commit/issue ID or PR for future reference so
maintainers understand why these thresholds were chosen.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2a415146-d163-44d4-aa50-b9d116f0e7bd

📥 Commits

Reviewing files that changed from the base of the PR and between 378add0 and 11506f5.

📒 Files selected for processing (1)
  • ci/validate_wheel.sh

@rgsl888prabhu rgsl888prabhu merged commit 81a61ef into NVIDIA:main Apr 9, 2026
76 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants