-
Notifications
You must be signed in to change notification settings - Fork 160
Add QCMATRIX: parsing and quadratic-constraint model #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuwenchen95
wants to merge
2
commits into
NVIDIA:main
Choose a base branch
from
yuwenchen95:mps-socp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validate non-negative CSR sizes before
resize.size_valuesandsize_indicesare signed (i_t). If either is negative,std::vector::resizecan convert to a huge unsigned size and trigger resource exhaustion.Proposed fix
void mps_data_model_t<i_t, f_t>::append_quadratic_constraint_matrix(i_t constraint_row_index, const f_t* Qc_values, i_t size_values, const i_t* Qc_indices, i_t size_indices, const i_t* Qc_offsets, i_t size_offsets) { mps_parser_expects( constraint_row_index >= 0, error_type_t::ValidationError, "constraint_row_index must be non-negative"); + mps_parser_expects( + size_values >= 0, error_type_t::ValidationError, "size_values cannot be negative"); + mps_parser_expects( + size_indices >= 0, error_type_t::ValidationError, "size_indices cannot be negative"); + mps_parser_expects( + size_offsets > 0, error_type_t::ValidationError, "size_offsets cannot be empty"); if (size_values != 0) { mps_parser_expects( Qc_values != nullptr, error_type_t::ValidationError, "Qc_values cannot be null"); } if (size_indices != 0) { mps_parser_expects( Qc_indices != nullptr, error_type_t::ValidationError, "Qc_indices cannot be null"); } mps_parser_expects( Qc_offsets != nullptr, error_type_t::ValidationError, "Qc_offsets cannot be null"); - mps_parser_expects( - size_offsets > 0, error_type_t::ValidationError, "size_offsets cannot be empty");As per coding guidelines, "Validate input sanitization to prevent buffer overflows and resource exhaustion attacks; avoid unsafe deserialization of problem files."
🤖 Prompt for AI Agents