Several fixes needed to compile cuOpt with LLVM#121
Merged
rapids-bot[bot] merged 3 commits intoNVIDIA:branch-25.08from Jul 2, 2025
Merged
Several fixes needed to compile cuOpt with LLVM#121rapids-bot[bot] merged 3 commits intoNVIDIA:branch-25.08from
rapids-bot[bot] merged 3 commits intoNVIDIA:branch-25.08from
Conversation
Collaborator
|
Thank you @vitor1001 for the PR, one of the reviewers should be reviewing it shortly. |
aliceb-nv
added
non-breaking
Contributor
|
/ok to test 69b3d8a |
Contributor
Author
|
note: updated the PR with check-style fixes |
Contributor
Author
|
Hi @aliceb-nv! Is there anything else you need from my side to merge this PR? |
rg20
reviewed
Jul 1, 2025
|
|
||
| #include <cub/cub.cuh> | ||
| #include <nvtx3/nvtx3.hpp> | ||
| // #include <nvtx3/nvtx3.hpp> |
Contributor
Author
There was a problem hiding this comment.
Good catch, removed.
hlinsen
reviewed
Jul 1, 2025
hlinsen
approved these changes
Jul 1, 2025
Contributor
|
/ok to test c5c8a0c |
- add std:: prefix to min() and max(); - add missing headers; - avoid calling std::optional::value() on device code since it can throw exceptions; - add "template" keyword to help parsing; - use a constexpr static method to define init_data(), to avoid using a not-yet-finished classes.
Contributor
|
/ok to test 9261b22 |
Contributor
Author
|
@hlinsen it looks like the single Python test breakage is a flaky test. Doesn't look related to any of the changes. |
Contributor
I confirm it is not related. I am re running the tests. |
Contributor
|
/ok to test dd94656 |
Contributor
|
/merge |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
- add std:: prefix to min() and max(); - add missing headers; - avoid calling std::optional::value() on device code since it can throw exceptions; - add "template" keyword to help parsing; - use a constexpr static method to define init_data(), to avoid using a not-yet-finished classes. Authors: - Vitor Sessak (https://github.com/vitor1001) Approvers: - Hugo Linsenmaier (https://github.com/hlinsen) URL: NVIDIA#121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist