Skip to content

Relax pinnings on several dependencies, remove nvidia channel#125

Merged
rapids-bot[bot] merged 5 commits intoNVIDIA:branch-25.08from
bdice:relax-pinnings
Jun 24, 2025
Merged

Relax pinnings on several dependencies, remove nvidia channel#125
rapids-bot[bot] merged 5 commits intoNVIDIA:branch-25.08from
bdice:relax-pinnings

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Jun 24, 2025 •
edited by rgsl888prabhu
Loading

Description

This relaxes some pinnings on numba-cuda, numba, and pandas to ensure that the latest nightly of cudf can be used. I also removed the nvidia channel as it is no longer needed.

This also fixes cuopt_cli test which was failing due to missing pyenv

@bdice bdice requested a review from a team as a code owner June 24, 2025 16:28
@bdice bdice requested a review from gforsyth June 24, 2025 16:28
@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 24, 2025
gforsyth
gforsyth requested changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of these changes also need to be set in the rattler recipes

@bdice bdice requested a review from gforsyth June 24, 2025 16:52
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jun 24, 2025

Good call @gforsyth, normally I catch myself on that but not this time!

gforsyth
gforsyth approved these changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

rgsl888prabhu commented Jun 24, 2025

Thank you @bdice for the PR.

@bdice bdice requested a review from a team as a code owner June 24, 2025 16:58
@bdice bdice requested a review from tmckayus June 24, 2025 16:58
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jun 24, 2025 •
edited
Loading

@rgsl888prabhu Could you take a quick peek at the install instructions? I just pushed some simplifications there while I was ripping out -c nvidia. We don't need to specify Python and CUDA minor versions in our install commands, it's best to let conda figure that out. It will work better with existing environments, and requires fewer updates on our side for every new CUDA/Python release.

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

rgsl888prabhu commented Jun 24, 2025

@rgsl888prabhu Could you take a quick peek at the install instructions? I just pushed some simplifications there while I was ripping out -c nvidia. We don't need to specify Python and CUDA minor versions in our install commands, it's best to let conda figure that out. It will work better with existing environments, and requires fewer updates on our side for every new CUDA/Python release.

cuOpt packages are in nvidia channel, I think intsall instruction would require nvidia channel for cuOpt. https://anaconda.org/nvidia/repo

@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jun 24, 2025

Sorry. Then my advice about removing nvidia only applies to RAPIDS and not cuOpt... I'll revert those changes.

@jameslamb jameslamb mentioned this pull request Jun 24, 2025
Merged
8 tasks
@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

rgsl888prabhu commented Jun 24, 2025

@bdice I am working on fixing the error in tests, will push it to this PR and also revert changes to README

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

rgsl888prabhu commented Jun 24, 2025

/merge

@rapids-bot rapids-bot bot merged commit d8bdad5 into NVIDIA:branch-25.08 Jun 24, 2025
72 checks passed
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
@bdice
Relax pinnings on several dependencies, remove nvidia channel (NVIDIA…
72e20aa 
…#125)

This relaxes some pinnings on numba-cuda, numba, and pandas to ensure that the latest nightly of cudf can be used. I also removed the `nvidia` channel as it is no longer needed.

This also fixes cuopt_cli test which was failing due to missing `pyenv`

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Gil Forsyth (https://github.com/gforsyth)
  - Trevor McKay (https://github.com/tmckayus)

URL: NVIDIA#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmckayus tmckayus tmckayus approved these changes

@gforsyth gforsyth gforsyth approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees

No one assigned

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bdice @rgsl888prabhu @tmckayus @gforsyth @jameslamb @anandhkb