Skip to content

Small improvements on how paths are handled in tests #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Jun 25, 2025
Merged

Small improvements on how paths are handled in tests #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d05ac31
Small improvements on how paths are handled in tests
vitor1001 Jun 25, 2025
4fd48ef
Merge branch 'branch-25.08' into test_fixes
vitor1001 Jun 25, 2025
b16dc45
Merge branch 'branch-25.08' into test_fixes
aliceb-nv Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions cpp/tests/mip/doc_example_test.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,23 +130,25 @@ TEST(docs, user_problem_file)
// Create the problem from documentation example
auto problem = create_doc_example_problem();

EXPECT_FALSE(std::filesystem::exists("user_problem.mps"));
const auto user_problem_path = std::filesystem::temp_directory_path() / "user_problem.mps";
EXPECT_FALSE(std::filesystem::exists(user_problem_path));

settings.time_limit = test_time_limit;
settings.user_problem_file = "user_problem.mps";
settings.user_problem_file = user_problem_path;
EXPECT_EQ(solve_mip(&handle_, problem, settings).get_termination_status(),
mip_termination_status_t::Optimal);

EXPECT_TRUE(std::filesystem::exists("user_problem.mps"));
EXPECT_TRUE(std::filesystem::exists(user_problem_path));

cuopt::mps_parser::mps_data_model_t<int, double> problem2 =
cuopt::mps_parser::parse_mps<int, double>("user_problem.mps", false);
cuopt::mps_parser::parse_mps<int, double>(user_problem_path, false);

EXPECT_EQ(problem2.get_n_variables(), problem.get_n_variables());
EXPECT_EQ(problem2.get_n_constraints(), problem.get_n_constraints());
EXPECT_EQ(problem2.get_nnz(), problem.get_nnz());

settings.user_problem_file = "user_problem2.mps";
const auto user_problem_path2 = std::filesystem::temp_directory_path() / "user_problem2.mps";
settings.user_problem_file = user_problem_path2;
mip_solution_t<int, double> solution = solve_mip(&handle_, problem2, settings);
EXPECT_EQ(solution.get_termination_status(), mip_termination_status_t::Optimal);

Expand Down
2 changes: 1 addition & 1 deletion cpp/tests/mip/feasibility_jump_tests.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ static fj_state_t run_fj(std::string test_instance,
const raft::handle_t handle_{};
std::cout << "Running: " << test_instance << std::endl;

auto path = "datasets/mip/" + test_instance;
auto path = cuopt::test::get_rapids_dataset_root_dir() + ("/mip/" + test_instance);
cuopt::mps_parser::mps_data_model_t<int, double> mps_problem =
cuopt::mps_parser::parse_mps<int, double>(path, false);
handle_.sync_stream();
Expand Down